Skip to content

Commit

Permalink
ALSA: remove CONFIG_KMOD from sound
Browse files Browse the repository at this point in the history
A bunch of things in alsa depend on CONFIG_KMOD,
use CONFIG_MODULES instead where the dependency
is needed at all.

Signed-off-by: Johannes Berg <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
Signed-off-by: Jaroslav Kysela <[email protected]>
  • Loading branch information
jmberg authored and perexg committed Jul 10, 2008
1 parent 7fc077f commit ee2da99
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 17 deletions.
2 changes: 1 addition & 1 deletion include/sound/seq_kernel.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ int snd_seq_event_port_attach(int client, struct snd_seq_port_callback *pcbp,
int cap, int type, int midi_channels, int midi_voices, char *portname);
int snd_seq_event_port_detach(int client, int port);

#ifdef CONFIG_KMOD
#ifdef CONFIG_MODULES
void snd_seq_autoload_lock(void);
void snd_seq_autoload_unlock(void);
#else
Expand Down
2 changes: 1 addition & 1 deletion sound/core/seq/seq_clientmgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ struct snd_seq_client *snd_seq_client_use_ptr(int clientid)
return NULL;
}
spin_unlock_irqrestore(&clients_lock, flags);
#ifdef CONFIG_KMOD
#ifdef CONFIG_MODULES
if (!in_interrupt()) {
static char client_requested[SNDRV_SEQ_GLOBAL_CLIENTS];
static char card_requested[SNDRV_CARDS];
Expand Down
6 changes: 2 additions & 4 deletions sound/core/seq/seq_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static void snd_seq_device_info(struct snd_info_entry *entry,
* load all registered drivers (called from seq_clientmgr.c)
*/

#ifdef CONFIG_KMOD
#ifdef CONFIG_MODULES
/* avoid auto-loading during module_init() */
static int snd_seq_in_init;
void snd_seq_autoload_lock(void)
Expand All @@ -140,7 +140,7 @@ void snd_seq_autoload_unlock(void)

void snd_seq_device_load_drivers(void)
{
#ifdef CONFIG_KMOD
#ifdef CONFIG_MODULES
struct ops_list *ops;

/* Calling request_module during module_init()
Expand Down Expand Up @@ -566,7 +566,5 @@ EXPORT_SYMBOL(snd_seq_device_load_drivers);
EXPORT_SYMBOL(snd_seq_device_new);
EXPORT_SYMBOL(snd_seq_device_register_driver);
EXPORT_SYMBOL(snd_seq_device_unregister_driver);
#ifdef CONFIG_KMOD
EXPORT_SYMBOL(snd_seq_autoload_lock);
EXPORT_SYMBOL(snd_seq_autoload_unlock);
#endif
8 changes: 4 additions & 4 deletions sound/core/sound.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,14 @@ EXPORT_SYMBOL(snd_ecards_limit);
static struct snd_minor *snd_minors[SNDRV_OS_MINORS];
static DEFINE_MUTEX(sound_mutex);

#ifdef CONFIG_KMOD
#ifdef CONFIG_MODULES

/**
* snd_request_card - try to load the card module
* @card: the card number
*
* Tries to load the module "snd-card-X" for the given card number
* via KMOD. Returns immediately if already loaded.
* via request_module. Returns immediately if already loaded.
*/
void snd_request_card(int card)
{
Expand All @@ -92,7 +92,7 @@ static void snd_request_other(int minor)
request_module(str);
}

#endif /* request_module support */
#endif /* modular kernel */

/**
* snd_lookup_minor_data - get user data of a registered device
Expand Down Expand Up @@ -132,7 +132,7 @@ static int snd_open(struct inode *inode, struct file *file)
return -ENODEV;
mptr = snd_minors[minor];
if (mptr == NULL) {
#ifdef CONFIG_KMOD
#ifdef CONFIG_MODULES
int dev = SNDRV_MINOR_DEVICE(minor);
if (dev == SNDRV_MINOR_CONTROL) {
/* /dev/aloadC? */
Expand Down
6 changes: 3 additions & 3 deletions sound/core/timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ static struct snd_timer *snd_timer_find(struct snd_timer_id *tid)
return NULL;
}

#ifdef CONFIG_KMOD
#ifdef CONFIG_MODULES

static void snd_timer_request(struct snd_timer_id *tid)
{
Expand Down Expand Up @@ -259,8 +259,8 @@ int snd_timer_open(struct snd_timer_instance **ti,
/* open a master instance */
mutex_lock(&register_mutex);
timer = snd_timer_find(tid);
#ifdef CONFIG_KMOD
if (timer == NULL) {
#ifdef CONFIG_MODULES
if (!timer) {
mutex_unlock(&register_mutex);
snd_timer_request(tid);
mutex_lock(&register_mutex);
Expand Down
2 changes: 0 additions & 2 deletions sound/ppc/daca.c
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,7 @@ int __init snd_pmac_daca_init(struct snd_pmac *chip)
int i, err;
struct pmac_daca *mix;

#ifdef CONFIG_KMOD
request_module("i2c-powermac");
#endif /* CONFIG_KMOD */

mix = kzalloc(sizeof(*mix), GFP_KERNEL);
if (! mix)
Expand Down
2 changes: 0 additions & 2 deletions sound/ppc/tumbler.c
Original file line number Diff line number Diff line change
Expand Up @@ -1350,9 +1350,7 @@ int __init snd_pmac_tumbler_init(struct snd_pmac *chip)
struct device_node *tas_node, *np;
char *chipname;

#ifdef CONFIG_KMOD
request_module("i2c-powermac");
#endif /* CONFIG_KMOD */

mix = kzalloc(sizeof(*mix), GFP_KERNEL);
if (! mix)
Expand Down

0 comments on commit ee2da99

Please sign in to comment.