Skip to content

Commit

Permalink
refactor: update isort configuration
Browse files Browse the repository at this point in the history
Use black profile, fix Makefile command, and run isort.
  • Loading branch information
ethanwu10 committed Jul 6, 2020
1 parent e4862de commit 8b861b7
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ flake8:

.PHONY: isort
isort:
$(POETRY) run isort -y
$(POETRY) run isort .
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ isort = "^5.0.4"
docs = ["sphinx", "sphinx_rtd_theme", "sphinx-jsonschema"]

[tool.isort]
line_length = 88
multi_line_output = 3 # conform to Black's style
include_trailing_comma = true
profile = "black"

[build-system]
requires = ["poetry>=0.12"]
Expand Down
3 changes: 2 additions & 1 deletion rcds/challenge/challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
from .config import ConfigLoader

if TYPE_CHECKING: # pragma: no cover
import rcds

from ..project import Project
from ..project.assets import AssetManagerContext, AssetManagerTransaction
import rcds


def _strip_scheme(url: str) -> str:
Expand Down
2 changes: 1 addition & 1 deletion rcds/challenge/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import pathspec # type: ignore

if TYPE_CHECKING: # pragma: no cover
from .challenge import Challenge
from ..project import Project
from .challenge import Challenge


def flatten(i: Iterable[Union[str, Iterable[str]]]) -> Iterable[str]:
Expand Down
3 changes: 2 additions & 1 deletion rcds/project/assets.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@
from warnings import warn

if TYPE_CHECKING: # pragma: no cover
from .project import Project
import rcds

from .project import Project


File = Union[BinaryIO, Path, bytes]
"""
Expand Down

0 comments on commit 8b861b7

Please sign in to comment.