Add an option to link platform.dill into app kernel file (flutter#4204)

refi64 · Oct 12, 2017 · 11cac67 · 11cac67
1 parent f737d49
commit 11cac67
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 6 deletions.
diff --git a/frontend_server/lib/server.dart b/frontend_server/lib/server.dart
@@ -30,7 +30,14 @@ ArgParser _argParser = new ArgParser(allowTrailingOptions: true)
   ..addOption('byte-store',
       help: 'Path to file byte store used to keep incremental compiler state.'
           ' If omitted, then memory byte store is used.',
-      defaultsTo: null);
+      defaultsTo: null)
+  ..addFlag('link-platform',
+      help: 'When in batch mode, link platform kernel file into result kernel file.'
+          ' Intended use is to satisfy different loading strategies implemented'
+          ' by gen_snapshot(which needs platform embedded) vs'
+          ' Flutter engine(which does not)',
+      defaultsTo: true);
+
 
 String _usage = '''
 Usage: server [options] [input.dart]
@@ -156,11 +163,13 @@ class _FrontendCompiler implements CompilerInterface {
       final DeltaProgram deltaProgram = await _generator.computeDelta();
       program = deltaProgram.newProgram;
     } else {
-      // TODO(aam): Remove linkedDependencies once platform is directly embedded
-      // into VM snapshot and http://dartbug.com/30111 is fixed.
-      compilerOptions.linkedDependencies = <Uri>[
-        sdkRoot.resolve('platform.dill')
-      ];
+      if (options['link-platform']) {
+        // TODO(aam): Remove linkedDependencies once platform is directly embedded
+        // into VM snapshot and http://dartbug.com/30111 is fixed.
+        compilerOptions.linkedDependencies = <Uri>[
+          sdkRoot.resolve('platform.dill')
+        ];
+      }
       program = await kernelForProgram(Uri.base.resolve(_filename), compilerOptions);
     }
     if (program != null) {

diff --git a/frontend_server/test/server_test.dart b/frontend_server/test/server_test.dart
@@ -69,6 +69,27 @@ Future<int> main() async {
       expect(capturedArgs.single['sdk-root'], equals('sdkroot'));
       expect(capturedArgs.single['byte-store'], equals('path/to/bytestore'));
     });
+
+    test('compile from command line with link platform', () async {
+      final List<String> args = <String>[
+        'server.dart',
+        '--sdk-root',
+        'sdkroot',
+        '--link-platform',
+      ];
+      final int exitcode = await starter(args, compiler: compiler);
+      expect(exitcode, equals(0));
+      final List<ArgResults> capturedArgs =
+          verify(
+              compiler.compile(
+                argThat(equals('server.dart')),
+                captureAny,
+                generator: any,
+              )
+          ).captured;
+      expect(capturedArgs.single['sdk-root'], equals('sdkroot'));
+      expect(capturedArgs.single['link-platform'], equals(true));
+    });
   });
 
   group('interactive file store compile with mocked compiler', () {