KAZOO-4362: make less calls to git-grep in check-app-registered.sh

regner · Jan 26, 2016 · 3a6ddb3 · 3a6ddb3
1 parent 42ef375
commit 3a6ddb3
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/scripts/check-app-registered.sh b/scripts/check-app-registered.sh
@@ -2,11 +2,15 @@
 
 # Usage:  $0 ‹path to an app›
 
-patterns=( ":start_link\\(\\{'local',\\s*" ":start_link\\(\\{local,\\s*" ':start_link\(' ':start_child\(' ':which_children\(' ':terminate_child\(' ':delete_child\(' ':call\(' ':cast\(' 'gen_listener:[^:\(]+\(' )
-
-
 [[ $# -eq 0 ]] && exit
 
+patterns=( ":start_link\\(\\{'local',\\s*" ":start_link\\(\\{local,\\s*" ':start_link\(' ':start_child\(' ':which_children\(' ':terminate_child\(' ':delete_child\(' ':call\(' ':cast\(' 'gen_listener:[^:\(]+\(' )
+re='('
+for pattern in ${patterns[@]}; do
+    re="$re"$pattern'|'
+done
+re=${re%%|}')'
+
 function registered() {
     local app="${1%%/}"
     local errors=0
@@ -17,11 +21,9 @@ function registered() {
         ((errors += 1))
     fi
 
-    for pattern in ${patterns[@]}; do
-        git grep -InE  $pattern'\?MODULE' -- $app/src
-        local count=0; [[ $? -eq 0 ]] && count=$(git grep -InE  $pattern'\?MODULE' -- $app/src | wc -l)
-        ((errors += $count))
-    done
+    git grep -InE $re'\?MODULE' -- $app/src
+    local count=0; [[ $? -eq 0 ]] && count=$(git grep -InE  $re'\?MODULE' -- $app/src | wc -l)
+    ((errors += $count))
 
     local app_src=$app/src/*.app.src
     git grep -InE  '\{registered, \[\]\}' -- $app_src >/dev/null