re-add empty, for nodiscard

rehdi93 · Nov 1, 2020 · 6b992d4 · 6b992d4
1 parent 75713a5
commit 6b992d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/include/red/sessions/session.hpp b/include/red/sessions/session.hpp
@@ -179,6 +179,9 @@ namespace detail {
             return ranges::distance(begin(), end());
         }
 
+        [[nodiscard]]
+        bool empty() const noexcept { return base::empty(); }
+
         template <class K, meta::is_strview_convertible<K> = true>
         void erase(K const& key) { do_erase(key); }
 

diff --git a/test/test.cpp b/test/test.cpp
@@ -59,15 +59,16 @@ TEST_CASE("get environment variables", "[environment]")
 {
     test_vars_guard _;
 
+    REQUIRE_FALSE(environment.empty());
+
     SECTION("operator[]")
     {
         for(auto[key, value] : TEST_VARS)
         {
-            string envvalue = environment[key];
-            REQUIRE(envvalue == value);
+            REQUIRE(string(environment[key]) == value);
         }
 
-        REQUIRE(environment["nonesuch"].operator std::string().empty());
+        REQUIRE(string(environment["nonesuch"]).empty());
     }
     SECTION("find()")
     {