Extractor v2 #21
Extractor v2 #21
Conversation
| @@ -535,35 +536,35 @@ type Poseidon1 struct { | |||
| In frontend.Variable | |||
| } | |||
|
|
|||
| func (g Poseidon1) DefineGadget(api abstractor.API) []frontend.Variable { | |||
| func (g Poseidon1) DefineGadget(api frontend.API) interface{} { | |||
There was a problem hiding this comment.
why not frontend.Variable anymore?
There was a problem hiding this comment.
Because we try to describe an interface which can return a single frontend.Variable or n-nested slices of frontend.Variable. interface{} is vanilla for everything. The user needs to know what to expect.
There was a problem hiding this comment.
right, but you can declare the return value as []frontend.Variable for the implementation and it still works with the interface, no?
There was a problem hiding this comment.
I.e. I understand why API has interface{} but not why the impl has it
There was a problem hiding this comment.
Because golang is strict and complains does not implement abstractor.GadgetDefinition
There was a problem hiding this comment.
can we use generics for this?
Summary
Details
Checklist