Skip to content

Commit

Permalink
feat(deploy-to-jexia): enable deploy of applications (runme-io#175)
Browse files Browse the repository at this point in the history
* feat(deploy-to-jexia): remove env vars from link

* fix(deploy-to-jexia): query params naming
  • Loading branch information
marlosin authored Jun 26, 2020
1 parent e40869d commit dddf41a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
2 changes: 0 additions & 2 deletions src/components/Stores/Header.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ function createHeader () {
timerTitle: '',
deployUrl: '',
dockerImage: '',
showPlaceholderDeployButton: false, // TODO remove when deployment is possible
failed: false,
failedStatus: '',
countDownFinish: false,
Expand All @@ -31,7 +30,6 @@ function createHeader () {
isFailed: (failed = true, failedStatus = 'Failed') => setHeaderValues({ failed, failedStatus }),
setCountDownFinish: (countDownFinish = true) => setHeaderValues({ countDownFinish }),
setDockerImage: (dockerImage) => setHeaderValues({ dockerImage }),
showPlaceholderDeploymentButton: (showPlaceholderDeployButton = true) => setHeaderValues({ showPlaceholderDeployButton }),
setApplicationUrl: (applicationUrl) => setHeaderValues({ applicationUrl }),
}
}
Expand Down
10 changes: 2 additions & 8 deletions src/routes/show.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -84,23 +84,17 @@
unsubscribe.application = application.subscribe(({
repo_branch: repoBranch,
repo_url: repoUrl,
env_variables: envVariables,
}) => {
if (repoBranch && repoUrl) {
const queryParam = {
repoUrl,
repoBranch,
env_vars: envVariables
? toQueryString(envVariables, ',')
: null,
repo_url: repoUrl,
repo_branch: repoBranch,
}
const queryString = toQueryString(queryParam)
const deploymentUrl = DEPLOYMENT.host.trim()
if (deploymentUrl) {
header.setDeploymentUrl(`https://${deploymentUrl}/runme?${queryString}`)
} else {
header.showPlaceholderDeploymentButton() // TODO remove once deployment is ready
}
}
})
Expand Down

0 comments on commit dddf41a

Please sign in to comment.