Skip to content

Commit

Permalink
dpif-netdev: Fix a couple of coding style issues.
Browse files Browse the repository at this point in the history
A couple of trivial fixes for a ternery operator placement
and pointer declaration.

Fixes: 655856e ("dpif-netdev: Change rxq_scheduling to use rxq processing cycles.")
Fixes: a2ac666 ("dpif-netdev: Change definitions of 'idle' & 'processing' cycles")
Cc: [email protected]
Reported-by: Ilya Maximets <[email protected]>
Signed-off-by: Kevin Traynor <[email protected]>
Acked-by: Ciara Loftus <[email protected]>
Signed-off-by: Darrell Ball <[email protected]>
  • Loading branch information
kevintraynor authored and darball1 committed Sep 5, 2017
1 parent 45df9fe commit 2808027
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions lib/dpif-netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -3427,8 +3427,8 @@ rr_numa_list_destroy(struct rr_numa_list *rr)
static int
rxq_cycle_sort(const void *a, const void *b)
{
struct dp_netdev_rxq * qa;
struct dp_netdev_rxq * qb;
struct dp_netdev_rxq *qa;
struct dp_netdev_rxq *qb;
uint64_t total_qa, total_qb;
unsigned i;

Expand Down Expand Up @@ -3863,9 +3863,10 @@ dpif_netdev_run(struct dpif *dpif)
dp_netdev_process_rxq_port(non_pmd,
port->rxqs[i].rx,
port->port_no);
cycles_count_intermediate(non_pmd, NULL, process_packets ?
PMD_CYCLES_PROCESSING
: PMD_CYCLES_IDLE);
cycles_count_intermediate(non_pmd, NULL,
process_packets
? PMD_CYCLES_PROCESSING
: PMD_CYCLES_IDLE);
}
}
}
Expand Down

0 comments on commit 2808027

Please sign in to comment.