Skip to content

Commit

Permalink
Fix broken GitHubApiTest integration test
Browse files Browse the repository at this point in the history
It's kinda interesting how the test was broken by this innocuous change:

pockethub@65348dd

The change is that the 'getRepositories()' method is no longer used in
the main app (replaced by 'getOrgRepositories()'), and so is stripped by
proguard, but it's still used in the integration test. With recent
changes to the android-maven-plugin, the contributing library is only
processed by proguard once, so the explicit usage in the integration
tests isn't enough to get the 'getRepositories()' method kept - an
explicit proguard rule has to be added.
  • Loading branch information
rtyley committed Mar 13, 2012
1 parent bce6542 commit ea458a2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions proguard.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,9 @@
-keep class * extends com.jcraft.jsch.KeyExchange
-keep class com.jcraft.jsch.**
-keepclassmembers class com.github.mobile.** { public <init>(...); }
-keep public class org.eclipse.egit.github.core.service.RepositoryService {
*** getRepositories(...);
}
-keep public class org.eclipse.egit.github.core.Repository {
*** getWatchers(...);
}

0 comments on commit ea458a2

Please sign in to comment.