Fix more big memory leaks

rel-s · Jul 30, 2017 · 246dd7f · 246dd7f
1 parent c1472e6
commit 246dd7f
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 3 deletions.
diff --git a/libr/bin/format/pe/pe.c b/libr/bin/format/pe/pe.c
@@ -877,6 +877,7 @@ int PE_(bin_pe_get_overlay)(struct PE_(r_bin_pe_obj_t)* bin, ut64* size) {
 
 	if ((ut64) bin->size > largest_offset + largest_size) {
 		*size = bin->size - largest_offset - largest_size;
+		free (sects);
 		return largest_offset + largest_size;
 	}
 	free (sects);

diff --git a/libr/core/disasm.c b/libr/core/disasm.c
@@ -3609,6 +3609,7 @@ R_API int r_core_print_disasm(RPrint *p, RCore *core, ut64 addr, ut8 *buf, int l
 		ds->vat = p2v (ds, ds->at);
 		if (r_cons_is_breaked ()) {
 			dorepeat = 0;
+			R_FREE (nbuf);
 			r_cons_break_pop ();
 			return 0; //break;
 		}

diff --git a/libr/core/project.c b/libr/core/project.c
@@ -285,6 +285,7 @@ R_API void r_core_project_execute_cmds(RCore *core, const char *prjfile) {
 	char *str = r_core_project_notes_file (core, prjfile);
 	char *data = r_file_slurp (str, NULL);
 	if (!data) {
+		free (str);
 		return;
 	}
 	Output out;

diff --git a/libr/egg/egg.c b/libr/egg/egg.c
@@ -55,9 +55,11 @@ R_API int r_egg_add (REgg *a, REggPlugin *foo) {
 		return false;
 	//if (foo->init)
 	//	foo->init (a->user);
-	r_list_foreach (a->plugins, iter, h)
-		if (!strcmp (h->name, foo->name))
+	r_list_foreach (a->plugins, iter, h) {
+		if (!strcmp (h->name, foo->name)) {
 			return false;
+		}
+	}
 	r_list_append (a->plugins, foo);
 	return true;
 }

diff --git a/libr/egg/egg_lang.c b/libr/egg/egg_lang.c
@@ -311,6 +311,7 @@ static void rcc_internal_mathop(REgg *egg, char *ptr, char *ep, char op) {
 	}
 	R_FREE (oldp);
 	R_FREE (ep);
+	R_FREE (p);
 }
 
 /*
@@ -1178,7 +1179,7 @@ static void rcc_next(REgg *egg) {
 				rcc_mathop (egg, &tmp, 2);
 				R_FREE (mathline);
 				tmp = NULL;
-				// following code block is too ugly, oh no
+				// following code block is too ugly, oh noes
 				p = r_egg_mkvar (egg, buf, ptr, 0);
 				if (is_var (p)) {
 					p = r_egg_mkvar (egg, buf, p, 0);

diff --git a/libr/io/p/io_debug.c b/libr/io/p/io_debug.c
@@ -232,6 +232,7 @@ static RRunProfile* _get_run_profile(RIO *io, int bits, char **argv) {
 	}
 	rp->_args[i] = NULL;
 	if (!argv[0]) {
+		r_run_free (rp);
 		return NULL;
 	}
 	rp->_program = strdup (argv[0]);