vfs_shadow_copy2: Preserve all open flags assuming ROFS

Instead of replacing open flags with just O_RDONLY, filter out all those flags unrelated to a Read Only File System BUG: https://bugzilla.samba.org/show_bug.cgi?id=14573 Signed-off-by: Anoop C S <[email protected]> Reviewed-by: Ralph Boehme <[email protected]> Autobuild-User(master): Ralph Böhme <[email protected]> Autobuild-Date(master): Thu Nov 12 17:23:19 UTC 2020 on sn-devel-184
remicollet · Nov 12, 2020 · e9e06a1 · e9e06a1
1 parent 8036bf9
commit e9e06a1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/source3/modules/vfs_shadow_copy2.c b/source3/modules/vfs_shadow_copy2.c
@@ -1351,7 +1351,7 @@ static int shadow_copy2_openat(vfs_handle_struct *handle,
 			 * EINVAL which we carefully map to EROFS. In sum, this
 			 * matches Windows behaviour.
 			 */
-			flags = O_RDONLY;
+			flags &= ~(O_WRONLY | O_RDWR | O_CREAT);
 		}
 		return SMB_VFS_NEXT_OPENAT(handle,
 					   dirfsp,
@@ -1385,7 +1385,7 @@ static int shadow_copy2_openat(vfs_handle_struct *handle,
 	 * pwrite() syscall with EINVAL which we carefully map to EROFS. In sum,
 	 * this matches Windows behaviour.
 	 */
-	flags = O_RDONLY;
+	flags &= ~(O_WRONLY | O_RDWR | O_CREAT);
 
 	ret = SMB_VFS_NEXT_OPENAT(handle,
 				  dirfsp,