Merge pull request ifsnop#63 from lukeb/master

Missing leading zeros in numeric string values
remisauvat · Sep 3, 2014 · 23bbbc4 · 23bbbc4
2 parents 2a3a135 + 526263a
commit 23bbbc4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Ifsnop/Mysqldump/Mysqldump.php b/src/Ifsnop/Mysqldump/Mysqldump.php
@@ -351,8 +351,9 @@ private function escape($arr)
         foreach ($arr as $val) {
             if (is_null($val)) {
                 $ret[] = "NULL";
-            } elseif (ctype_digit($val)) {
-                // faster than "(string) intval($val) === $val"
+            } elseif (ctype_digit($val) && (string) intval($val) === $val) {
+            	// Since "(string) intval($val) === $val" is slower, first check ctype_digit, then run comparison
+            	// We can't use ctype_digit alone, as this will trim off leading zeros on string values
                 // but will quote negative integers (not a big deal IMHO)
                 $ret[] = $val;
             } else {