small speed improvement, move assignment outside loop

remisauvat · Sep 8, 2014 · f52c6a2 · f52c6a2
1 parent b79e513
commit f52c6a2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Ifsnop/Mysqldump/Mysqldump.php b/src/Ifsnop/Mysqldump/Mysqldump.php
@@ -498,10 +498,11 @@ private function getViewStructure($viewName)
     private function escape($tableName, $row)
     {
         $ret = array();
+        $columnTypes = $this->tableColumnTypes[$tableName];
         foreach ($row as $colName => $colValue) {
             if (is_null($colValue)) {
                 $ret[] = "NULL";
-            } elseif ($this->tableColumnTypes[$tableName][$colName]) {
+            } elseif ($columnTypes[$colName]) {
                 // if (ctype_digit($val) && ((string) intval($val) === $val)) {
                 // Since "(string) intval($val) === $val" is slower, first check ctype_digit, then run comparison
                 // We can't use ctype_digit alone, as this will trim off leading zeros on string values