Skip to content

Commit

Permalink
drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit()
Browse files Browse the repository at this point in the history
When we look at i915_request_is_started() we must be careful in case we
are using a request that does not have the initial-breadcrumb and
instead the is-started is being compared against the end of the previous
request. This will make wait_for_submit() declare that a request has
been already submitted too early.

Signed-off-by: Chris Wilson <[email protected]>
Reviewed-by: Mika Kuoppala <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
ickle committed May 19, 2020
1 parent 3a230a5 commit f73fbb5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/gt/selftest_lrc.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ static bool is_active(struct i915_request *rq)
if (i915_request_on_hold(rq))
return true;

if (i915_request_started(rq))
if (i915_request_has_initial_breadcrumb(rq) && i915_request_started(rq))
return true;

return false;
Expand Down

0 comments on commit f73fbb5

Please sign in to comment.