Skip to content

Commit

Permalink
Change the skip function for multus genie and sriov.
Browse files Browse the repository at this point in the history
Check of the daemonsets exist on the kube-system namespace.
  • Loading branch information
SchSeba committed Dec 18, 2018
1 parent d0150d5 commit 7f898df
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions automation/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ if [[ $TARGET =~ openshift-.* ]]; then
fi
elif [[ $TARGET =~ .*-1.10.4-.* ]]; then
export KUBEVIRT_PROVIDER="k8s-1.10.4"
elif [[ $TARGET =~ .*-multus-1.11.1-.* ]]; then
export KUBEVIRT_PROVIDER="k8s-multus-1.11.1"
elif [[ $TARGET =~ .*-multus-1.12.2-.* ]]; then
export KUBEVIRT_PROVIDER="k8s-multus-1.12.2"
elif [[ $TARGET =~ .*-genie-1.11.1-.* ]]; then
export KUBEVIRT_PROVIDER="k8s-genie-1.11.1"
else
Expand Down
6 changes: 3 additions & 3 deletions tests/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -1955,21 +1955,21 @@ func SkipIfNoRhelImage(virtClient kubecli.KubevirtClient) {
}

func SkipIfNoSriovDevicePlugin(virtClient kubecli.KubevirtClient) {
_, err := virtClient.ExtensionsV1beta1().DaemonSets(KubeVirtInstallNamespace).Get("kube-sriov-device-plugin-amd64", metav1.GetOptions{})
_, err := virtClient.ExtensionsV1beta1().DaemonSets(metav1.NamespaceSystem).Get("kube-sriov-device-plugin-amd64", metav1.GetOptions{})
if err != nil {
Skip("Skip srio tests that required sriov device plugin")
}
}

func SkipIfNoMultusProvider(virtClient kubecli.KubevirtClient) {
_, err := virtClient.ExtensionsV1beta1().DaemonSets(KubeVirtInstallNamespace).Get("kube-multus-ds-amd64", metav1.GetOptions{})
_, err := virtClient.ExtensionsV1beta1().DaemonSets(metav1.NamespaceSystem).Get("kube-multus-ds-amd64", metav1.GetOptions{})
if err != nil {
Skip("Skip multus tests that required multus cni plugin")
}
}

func SkipIfNoGenieProvider(virtClient kubecli.KubevirtClient) {
_, err := virtClient.ExtensionsV1beta1().DaemonSets("kube-system").Get("genie-plugin", metav1.GetOptions{})
_, err := virtClient.ExtensionsV1beta1().DaemonSets(metav1.NamespaceSystem).Get("genie-plugin", metav1.GetOptions{})
if err != nil {
Skip("Skip genie tests that required genie cni plugin")
}
Expand Down
2 changes: 1 addition & 1 deletion tests/vmi_networking_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ var _ = Describe("Networking", func() {
var cmdCheck, addrShow, addr string

if destination == "InboundVMIWithCustomMacAddress" {
tests.SkipIfOpenShift("Custom MAC addresses on pod networks are not suppored")
tests.SkipIfOpenShift("Custom MAC addresses on pod networks are not supported")
}

// assuming pod network is of standard MTU = 1500 (minus 50 bytes for vxlan overhead)
Expand Down

0 comments on commit 7f898df

Please sign in to comment.