performance optimalizations + avoid memory usage increasing infinitely

k8s/contiv-vpp-arm64.yaml

@@ -99,6 +99,9 @@ data:
     dump-go-routines-count: 5
   linux-l3plugin.conf: |
     dump-go-routines-count: 5
+  kvscheduler.conf: |
+    record-transaction-history: true
+    transaction-history-age-limit: 1440
 
 ---
 
@@ -414,6 +417,8 @@ spec:
               value: "/etc/vpp-agent/linux-ifplugin.conf"
             - name: LINUX_L3PLUGIN_CONFIG
               value: "/etc/vpp-agent/linux-l3plugin.conf"
+            - name: KVSCHEDULER_CONFIG
+              value: "/etc/vpp-agent/kvscheduler.conf"
           volumeMounts:
             - name: var-bolt
               mountPath: /var/bolt

k8s/contiv-vpp.yaml

@@ -99,6 +99,9 @@ data:
     dump-go-routines-count: 5
   linux-l3plugin.conf: |
     dump-go-routines-count: 5
+  kvscheduler.conf: |
+    record-transaction-history: true
+    transaction-history-age-limit: 1440
 
 ---
 
@@ -412,6 +415,8 @@ spec:
               value: "/etc/vpp-agent/linux-ifplugin.conf"
             - name: LINUX_L3PLUGIN_CONFIG
               value: "/etc/vpp-agent/linux-l3plugin.conf"
+            - name: KVSCHEDULER_CONFIG
+              value: "/etc/vpp-agent/kvscheduler.conf"
           volumeMounts:
             - name: var-bolt
               mountPath: /var/bolt

k8s/contiv-vpp/templates/vpp.yaml

@@ -156,6 +156,9 @@ data:
     dump-go-routines-count: 5
   linux-l3plugin.conf: |
     dump-go-routines-count: 5
+  kvscheduler.conf: |
+    record-transaction-history: {{ .Values.controller.recordEventHistory }}
+    transaction-history-age-limit: {{ .Values.controller.eventHistoryAgeLimit }}
 
 ---
 
@@ -705,6 +708,8 @@ spec:
               value: "/etc/vpp-agent/linux-ifplugin.conf"
             - name: LINUX_L3PLUGIN_CONFIG
               value: "/etc/vpp-agent/linux-l3plugin.conf"
+            - name: KVSCHEDULER_CONFIG
+              value: "/etc/vpp-agent/kvscheduler.conf"
           volumeMounts:
             - name: var-bolt
               mountPath: /var/bolt

mock/localclient/controller/txn.go

@@ -14,7 +14,7 @@ import (
 
 // MockControllerTxn is a mock implementation of the Transaction interface from Controller.
 type MockControllerTxn struct {
-	seqNum     int
+	seqNum     uint64
 	Values     controller.KeyValuePairs
 	commitFunc CommitFunc
 }
@@ -24,7 +24,7 @@ type MockControllerTxn struct {
 type CommitFunc = func(values map[string]proto.Message) error
 
 // NewMockControllerTxn is a constructor for mock Controller Txn.
-func NewMockControllerTxn(seqNum int, commitFunc CommitFunc) *MockControllerTxn {
+func NewMockControllerTxn(seqNum uint64, commitFunc CommitFunc) *MockControllerTxn {
 	return &MockControllerTxn{
 		seqNum:     seqNum,
 		Values:     make(controller.KeyValuePairs),
@@ -33,7 +33,7 @@ func NewMockControllerTxn(seqNum int, commitFunc CommitFunc) *MockControllerTxn
 }
 
 // Commit applies the requested transaction changes.
-func (m *MockControllerTxn) Commit(ctx context.Context) (seqNum int, err error) {
+func (m *MockControllerTxn) Commit(ctx context.Context) (seqNum uint64, err error) {
 	resyncType, _ := scheduler_api.IsResync(ctx)
 	isResync := resyncType != scheduler_api.NotResync
 	description, withDescription := scheduler_api.IsWithDescription(ctx)

mock/localclient/txn.go

@@ -22,7 +22,7 @@ type TxnTracker struct {
 	// lock allows to use the same mock localclient from multiple go routines.
 	lock sync.Mutex
 	// next transaction sequence number
-	txnSeqNum int
+	txnSeqNum uint64
 	// LatestRevisions maintains the map of keys & values with revision.
 	LatestRevisions *syncbase.PrevRevisions
 	// CommittedTxns is a list finalized transaction in the order as they were

plugins/controller/api/txn.go

@@ -25,7 +25,7 @@ type Transaction interface {
 	UpdateOperations
 
 	// Commit applies the requested transaction changes.
-	Commit(ctx context.Context) (seqNum int, err error)
+	Commit(ctx context.Context) (seqNum uint64, err error)
 }
 
 // ResyncOperations lists operations needed to build transaction for Resync-type events.

plugins/controller/plugin_controller.go

@@ -446,7 +446,9 @@ func (c *Controller) eventLoop() {
 					break
 				}
 			}
-			c.eventHistory = c.eventHistory[i:]
+			if i > 0 {
+				c.eventHistory = c.eventHistory[i:]
+			}
 			c.historyLock.Unlock()
 		}
 	}
@@ -742,8 +744,8 @@ func (c *Controller) processEvent(qe *QueuedEvent) error {
 		}
 
 		// append transaction to the event record
-		if txnSeqNum != -1 {
-			evRecord.Txn = c.Scheduler.GetRecordedTransaction(uint(txnSeqNum))
+		if txnSeqNum != ^uint64(0) {
+			evRecord.Txn = c.Scheduler.GetRecordedTransaction(txnSeqNum)
 		}
 
 		// update Controller's view of internal configuration

plugins/controller/txn.go

@@ -52,7 +52,7 @@ func newTransaction(kvScheduler scheduler_api.KVScheduler) *kvSchedulerTxn {
 }
 
 // Commit applies the requested transaction changes.
-func (txn *kvSchedulerTxn) Commit(ctx context.Context) (seqNum int, err error) {
+func (txn *kvSchedulerTxn) Commit(ctx context.Context) (seqNum uint64, err error) {
 	schedTxn := txn.kvScheduler.StartNBTransaction()
 	for key, value := range txn.values {
 		if value != nil {