Improve error message when deploying notebooks without settings (live…

…book-dev#2008)
repos-elixir · Jun 25, 2023 · ebab482 · ebab482
1 parent 05d691d
commit ebab482
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/livebook/apps.ex b/lib/livebook/apps.ex
@@ -188,7 +188,9 @@ defmodule Livebook.Apps do
         warnings = Enum.map(warnings, &("Import: " <> &1))
         deploy(notebook, warnings: warnings)
       else
-        Logger.warning("Skipping app deployment at #{path} due to invalid settings")
+        Logger.warning(
+          "Skipping app deployment at #{path}. The deployment settings are missing or invalid. Please configure them under the notebook deploy panel."
+        )
       end
     end
 

diff --git a/test/livebook/apps_test.exs b/test/livebook/apps_test.exs
@@ -49,7 +49,8 @@ defmodule Livebook.AppsTest do
 
       assert capture_log(fn ->
                Livebook.Apps.deploy_apps_in_dir(tmp_dir)
-             end) =~ "Skipping app deployment at #{app_path} due to invalid settings"
+             end) =~
+               "Skipping app deployment at #{app_path}. The deployment settings are missing or invalid. Please configure them under the notebook deploy panel."
     end
 
     @tag :tmp_dir