Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publikator): add uuid as a dependency #775

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

trm217
Copy link
Contributor

@trm217 trm217 commented Apr 3, 2024

I stumbled upon this error and found this.

@trm217 trm217 added bug Something isn't working app: publikator Publikator frontend server labels Apr 3, 2024
@trm217 trm217 self-assigned this Apr 3, 2024
@trm217 trm217 requested a review from jstcki April 3, 2024 09:18
yarn.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@jstcki jstcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, please make sure this actually works, since we have multiple uuid version flying around IIRC

@trm217
Copy link
Contributor Author

trm217 commented Apr 3, 2024

Fixes #776

@trm217 trm217 linked an issue Apr 3, 2024 that may be closed by this pull request
@trm217 trm217 force-pushed the fix-publikator-missing-uuid-dependency branch from 63395e7 to 132366c Compare April 3, 2024 10:00
@trm217
Copy link
Contributor Author

trm217 commented Apr 3, 2024

@jstcki uuid has a more or less stable api since v3. v3, for some reason is only used in nextjs-apollo-client, in all other packages we use v >= 8. I'll update nextjs apollo client in a separate pr

Unverified

No user is associated with the committer email.
@trm217 trm217 force-pushed the fix-publikator-missing-uuid-dependency branch from 132366c to 764fa2a Compare April 3, 2024 10:02
@trm217 trm217 merged commit 7ad1733 into main Apr 3, 2024
4 checks passed
@trm217 trm217 deleted the fix-publikator-missing-uuid-dependency branch April 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: publikator Publikator frontend server bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'uuid'
2 participants