Convert to PPXlib #68
Conversation
|
Hey @anmonteiro thanks for the PR! Looking at it now. I've noticed that Travis hasn't been picking up new PRs/branches for build. I think it may be because the repo was added to the reasonml-labs org? I sent a request to the org for Travis to access this repo, let me know if you see that request and/or are able to get Travis builds working for the org/repo. Thanks! |
anmonteiro
force-pushed
the
anmonteiro/convert-to-ppxlib
branch
from
229b04d to
2a8ff66
Compare
|
Done |
ppx_src/bin/Utils.re
Outdated
| /* |> (v) => Location.Error(v) */ | ||
| /* |> raise; */ |
There was a problem hiding this comment.
Is Location.raise_errorf equivalent to the previous code? Is it necessary to keep this commented code around?
There was a problem hiding this comment.
it is. I don't know why I kept it!
|
Thanks @ryb73, I just fixed the CI build and addressed your comments. |
|
Thanks @anmonteiro ! |
| @@ -12,7 +13,7 @@ script: | |||
| - yarn build-ppx | |||
| - yarn build-lib | |||
| - npm test | |||
| - mv ppx_src/_esy/default/build/default/.ppx/ppx_decco/ppx.exe ppx-$TRAVIS_OS_NAME.exe | |||
| - mv ppx_src/_esy/default/build/install/default/lib/ppx_decco/ppx.exe ppx-$TRAVIS_OS_NAME.exe | |||
There was a problem hiding this comment.
I'm not sure this is correct, when I tried building it that ppx.exe is a symlink.
This PR converts
deccoto use ppxlib. The conversion is straightforward. I structured it into 2 commits:ppx_src/package.jsonand commits the esy lockfile directoryNote that, while we're building the PPX with OCaml 4.12, it works well with a current ReScript compiler (on 4.06) – ppxlib does the heavy lifting here.
Test plan
npm testpasses.