tests: clean up some tests to avoid build error with stale output

[aspeddro]

No description provided.

[cometkim]

I don't think this is a good place to do the clean task.

The pipeline is managed by the Makefile: test -> lib (build test) -> build (build compiler)

If the goal is to get a clean build before running tests, you should use a config file instead of inserting the task into the middle of the test script. You could also make lib always guarantee that, but I don't prefer either because I want incremental builds during development.

There is no need for additional dependencies or script, since rescript clean does exactly what you need.

[aspeddro]

Ok, but currently some tests don't have incremental compilation. I think what happened was that they forgot to add a step to clean tests/build_tests

Mocha test run rescript clean. I can change to rescript clean

[cristianoc]

Ok, but currently some tests don't have incremental compilation. I think what happened was that they forgot to add a step to clean tests/build_tests

Mocha test run rescript clean. I can change to rescript clean

A bunch of those tests self clean.
Being some of the oldest tests around, these are most outdated one.
If you know which ones are problematic, one can add a clean step as e.g. in build_tests/cycle1/input.js.

[aspeddro]

I added a cleaning step in the tests where I saw the most errors with stale outputs.

[cometkim]

Thanks @aspeddro