Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use experimental JSON import feature #7379

Merged
merged 2 commits into from
Apr 5, 2025
Merged

Do not use experimental JSON import feature #7379

merged 2 commits into from
Apr 5, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Apr 5, 2025

Closes #7372

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: e5d349d Previous: 3f06468 Ratio
Print HeroGraphic.res - time/run 26.426541386666663 ms 7.840572506666666 ms 3.37
Print HeroGraphic.res - allocs/run 10571467 words 1396448 words 7.57

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt cknitt merged commit 7861628 into master Apr 5, 2025
20 checks passed
@cknitt cknitt deleted the no-json-import branch April 5, 2025 14:14
@cometkim
Copy link
Member

cometkim commented Apr 5, 2025

This reads and parses package.json reduantly, unlike modules. Which is fine, but if it would be needed in somewhere in cli, it might be need to be extracted a module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node warning 1335254 using node v20.12.0
3 participants