MDL-59362 core: ensure we use 'new' when throwing exceptions

reskit · Jun 26, 2017 · 6d721ca · 6d721ca
1 parent f4a2d69
commit 6d721ca
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/classes/plugin_manager.php b/lib/classes/plugin_manager.php
@@ -146,7 +146,7 @@ public static function reset_caches($phpunitreset = false) {
     public function get_plugin_types() {
         if (func_num_args() > 0) {
             if (!func_get_arg(0)) {
-                throw coding_exception('core_plugin_manager->get_plugin_types() does not support relative paths.');
+                throw new coding_exception('core_plugin_manager->get_plugin_types() does not support relative paths.');
             }
         }
         if ($this->plugintypes) {

diff --git a/lib/navigationlib.php b/lib/navigationlib.php
@@ -3651,7 +3651,7 @@ public function __construct($navnode) {
                  $this->$key = $value;
             }
         } else {
-            throw coding_exception('Not a valid breadcrumb_navigation_node');
+            throw new coding_exception('Not a valid breadcrumb_navigation_node');
         }
     }
 
@@ -3705,7 +3705,7 @@ public function __construct($navnode, $indent) {
                  $this->$key = $value;
             }
         } else {
-            throw coding_exception('Not a valid flat_navigation_node');
+            throw new coding_exception('Not a valid flat_navigation_node');
         }
         $this->indent = $indent;
     }

diff --git a/tag/classes/collection.php b/tag/classes/collection.php
@@ -303,7 +303,7 @@ public static function delete($tagcoll) {
     public static function change_sortorder($tagcoll, $direction) {
         global $DB;
         if ($direction != -1 && $direction != 1) {
-            throw coding_exception('Second argument in tag_coll_change_sortorder() can be only 1 or -1');
+            throw new coding_exception('Second argument in tag_coll_change_sortorder() can be only 1 or -1');
         }
         $tagcolls = self::get_collections();
         $keys = array_keys($tagcolls);