Minor recordset cleanup

lib/dml/adodb_moodle_recordset.php

@@ -7,7 +7,8 @@
  * @package dmlib
  */
 class adodb_moodle_recordset extends moodle_recordset {
-    private $rs;
+
+    protected $rs; ///ADOdb recordset
 
     public function __construct($rs) {
         $this->rs = $rs;

lib/dml/oci8po_adodb_moodle_recordset.php

@@ -7,39 +7,12 @@
  * @package dmlib
  */
 class oci8po_adodb_moodle_recordset extends adodb_moodle_recordset {
-    private $rs;
-
-    public function __construct($rs) {
-        $this->rs = $rs;
-    }
 
     public function current() {
         /// Really DIRTY HACK for Oracle - needed because it can not see difference from NULL and ''
-        /// this can not be removed even if we chane db defaults :-(
+        /// this can not be removed even if we change db defaults :-(
         $fields = $this->rs->fields;
         array_walk($fields, array('oci8po_adodb_moodle_database', 'onespace2empty'));
         return (object)$fields;
     }
-
-    public function key() {
-        return $this->rs->_currentRow;
-    }
-
-    public function next() {
-        $this->rs->MoveNext();
-    }
-
-    public function rewind() {
-        //TODO - this does not work in Oracle :-(
-        error('Implement rewind in oracle by doing query again');
-        $this->rs->MoveFirst();
-    }
-
-    public function valid() {
-        return !$this->rs->EOF;
-    }
-
-    public function close() {
-        $this->rs->Close();
-    }
 }

lib/dml/pdo_moodle_recordset.php

@@ -7,6 +7,7 @@
  * @package dmlib
  */
 class pdo_moodle_recordset extends moodle_recordset {
+
     private $sht;
 
     public function __construct($sth) {