MDL-24090 new detection of plugins that were not upgraded to work wit…

…h Moodle 2.x (uses $plugin->requires) + bumping ancient versions of plugins
reskit · Sep 5, 2010 · ef14c1e · ef14c1e
1 parent d32fb55
commit ef14c1e
Show file tree

Hide file tree

Showing 49 changed files with 106 additions and 93 deletions.
diff --git a/admin/report/courseoverview/version.php b/admin/report/courseoverview/version.php
@@ -23,5 +23,5 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101503;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
diff --git a/admin/report/questioninstances/version.php b/admin/report/questioninstances/version.php
@@ -23,5 +23,5 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101502;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
diff --git a/admin/report/security/version.php b/admin/report/security/version.php
@@ -23,5 +23,5 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2008122900;
-$plugin->requires = 2008121701;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
diff --git a/admin/report/unittest/version.php b/admin/report/unittest/version.php
@@ -23,6 +23,6 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2008112601;
-$plugin->requires = 2008112600;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
diff --git a/blocks/tags/version.php b/blocks/tags/version.php
@@ -15,4 +15,5 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version = 2008063001;
+$plugin->version  = 2010090502;
+$plugin->requires = 2010090501;
diff --git a/course/report/completion/version.php b/course/report/completion/version.php
@@ -23,5 +23,5 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101501;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
diff --git a/course/report/log/version.php b/course/report/log/version.php
@@ -23,7 +23,7 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101504;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/course/report/outline/version.php b/course/report/outline/version.php
@@ -23,7 +23,7 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101501;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/course/report/participation/version.php b/course/report/participation/version.php
@@ -23,7 +23,7 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101501;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/course/report/progress/version.php b/course/report/progress/version.php
@@ -23,7 +23,7 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101500;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/course/report/stats/version.php b/course/report/stats/version.php
@@ -23,7 +23,7 @@
 //                                                                       //
 ///////////////////////////////////////////////////////////////////////////
 
-$plugin->version  = 2007101501;
-$plugin->requires = 2007101532;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/enrol/authorize/version.php b/enrol/authorize/version.php
@@ -27,5 +27,5 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->version  = 2010081203;
-$plugin->requires = 2007101507;
+$plugin->requires = 2010090501;
 $plugin->cron = 180;
diff --git a/enrol/paypal/version.php b/enrol/paypal/version.php
@@ -27,4 +27,4 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->version  = 2010073100;
-$plugin->requires = 2007101000;   // Requires this Moodle version
+$plugin->requires = 2010090501;   // Requires this Moodle version
diff --git a/grade/export/ods/version.php b/grade/export/ods/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007092701;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/export/txt/version.php b/grade/export/txt/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007092700;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/export/xls/version.php b/grade/export/xls/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007092700;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/export/xml/version.php b/grade/export/xml/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007092700;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/import/csv/version.php b/grade/import/csv/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007072500;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/import/xml/version.php b/grade/import/xml/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007092700;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/report/grader/version.php b/grade/report/grader/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2009022500;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/report/outcomes/version.php b/grade/report/outcomes/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007073000;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/report/overview/version.php b/grade/report/overview/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2009022500;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/grade/report/user/version.php b/grade/report/user/version.php
@@ -15,7 +15,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-$plugin->version  = 2007092500;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/lib/editor/textarea/version.php b/lib/editor/textarea/version.php
@@ -26,5 +26,5 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version  = 2009051400;
-$plugin->requires = 2009051200;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
diff --git a/lib/upgradelib.php b/lib/upgradelib.php
@@ -290,6 +290,8 @@ function upgrade_plugins($type, $startcallback, $endcallback, $verbose) {
         if (!empty($plugin->requires)) {
             if ($plugin->requires > $CFG->version) {
                 throw new upgrade_requires_exception($component, $plugin->version, $CFG->version, $plugin->requires);
+            } else if ($plugin->requires < 2010000000) {
+                throw new plugin_defective_exception($component, 'Plugin is not compatible with Moodle 2.x or later.');
             }
         }
 
@@ -419,6 +421,8 @@ function upgrade_plugins_modules($startcallback, $endcallback, $verbose) {
         if (!empty($module->requires)) {
             if ($module->requires > $CFG->version) {
                 throw new upgrade_requires_exception($component, $module->version, $CFG->version, $module->requires);
+            } else if ($module->requires < 2010000000) {
+                throw new plugin_defective_exception($component, 'Plugin is not compatible with Moodle 2.x or later.');
             }
         }
 
@@ -553,6 +557,14 @@ function upgrade_plugins_blocks($startcallback, $endcallback, $verbose) {
         include($fullblock.'/version.php');
         $block = $plugin;
 
+        if (!empty($plugin->requires)) {
+            if ($plugin->requires > $CFG->version) {
+                throw new upgrade_requires_exception($component, $plugin->version, $CFG->version, $plugin->requires);
+            } else if ($plugin->requires < 2010000000) {
+                throw new plugin_defective_exception($component, 'Plugin is not compatible with Moodle 2.x or later.');
+            }
+        }
+
         if (!is_readable($fullblock.'/block_'.$blockname.'.php')) {
             throw new plugin_defective_exception('block/'.$blockname, 'Missing main block class file.');
         }

diff --git a/message/output/email/version.php b/message/output/email/version.php
@@ -32,7 +32,7 @@
  */
 
 
-$plugin->version  = 2008072401;
-$plugin->requires = 2008072401;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/message/output/jabber/version.php b/message/output/jabber/version.php
@@ -31,7 +31,7 @@
  * @package
  */
 
-$plugin->version  = 2008090900;
-$plugin->requires = 2008091500;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/message/output/popup/version.php b/message/output/popup/version.php
@@ -31,7 +31,7 @@
  * @package
  */
 
-$plugin->version  = 2008072401;
-$plugin->requires = 2008072401;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 
 
diff --git a/mod/assignment/type/online/version.php b/mod/assignment/type/online/version.php
@@ -5,7 +5,7 @@
 //  This fragment is called by /admin/index.php
 ////////////////////////////////////////////////////////////////////////////////
 
-$plugin->version   = 2005042900;
-$plugin->requires  = 2007101000;
+$plugin->version   = 2010090501;
+$plugin->requires  = 2010090501;
 
 
diff --git a/mod/workshop/eval/best/version.php b/mod/workshop/eval/best/version.php
@@ -25,5 +25,5 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version  = 2009103000;
-$plugin->requires = 2009100605;  // Requires this Moodle version
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;  // Requires this Moodle version
diff --git a/mod/workshop/form/accumulative/version.php b/mod/workshop/form/accumulative/version.php
@@ -28,5 +28,5 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version  = 2009103000;
-$plugin->requires = 2009080700;  // Requires this Moodle version
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;  // Requires this Moodle version
diff --git a/mod/workshop/form/comments/version.php b/mod/workshop/form/comments/version.php
@@ -28,5 +28,5 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version  = 2009103000;
-$plugin->requires = 2009102600;  // Requires this Moodle version
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;  // Requires this Moodle version
diff --git a/mod/workshop/form/numerrors/version.php b/mod/workshop/form/numerrors/version.php
@@ -28,5 +28,5 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version  = 2009103000;
-$plugin->requires = 2009080700;  // Requires this Moodle version
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;  // Requires this Moodle version
diff --git a/mod/workshop/form/rubric/version.php b/mod/workshop/form/rubric/version.php
@@ -28,5 +28,5 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version  = 2009103000;
-$plugin->requires = 2009100600;  // Requires this Moodle version
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;  // Requires this Moodle version
diff --git a/portfolio/boxnet/version.php b/portfolio/boxnet/version.php
@@ -1,7 +1,7 @@
 <?php
 
-$plugin->version  = 2008072500;
-$plugin->requires = 2008072500;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 $plugin->cron     = 0;
 
 
diff --git a/portfolio/download/version.php b/portfolio/download/version.php
@@ -1,7 +1,7 @@
 <?php
 
-$plugin->version  = 2008072500;
-$plugin->requires = 2008072500;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 $plugin->cron     = 0;
 
 
diff --git a/portfolio/flickr/version.php b/portfolio/flickr/version.php
@@ -1,7 +1,7 @@
 <?php
 
-$plugin->version  = 2008072500;
-$plugin->requires = 2008072500;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 $plugin->cron     = 0;
 
 
diff --git a/portfolio/googledocs/version.php b/portfolio/googledocs/version.php
@@ -1,6 +1,6 @@
 <?php
 
-$plugin->version  = 2008072505;
-$plugin->requires = 2008072500;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 $plugin->cron     = 0;
 
diff --git a/portfolio/mahara/version.php b/portfolio/mahara/version.php
@@ -25,8 +25,8 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-$plugin->version  = 2010021800;
-$plugin->requires = 2008072500;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 $plugin->cron     = 0;
 
 
diff --git a/portfolio/picasa/version.php b/portfolio/picasa/version.php
@@ -1,7 +1,7 @@
 <?php
 
-$plugin->version  = 2008072505;
-$plugin->requires = 2008072500;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;
 $plugin->cron     = 0;
 
 
diff --git a/question/type/calculated/version.php b/question/type/calculated/version.php
@@ -1,5 +1,5 @@
 <?PHP
 
-$plugin->version  = 2010020801;
-$plugin->requires = 2007101000;
+$plugin->version  = 2010090501;
+$plugin->requires = 2010090501;