mention POSIXct in error messages when using POSIXlt.

closes tidyverse#3735
rfaelens · May 28, 2019 · e08aee1 · e08aee1
1 parent d1b3bf5
commit e08aee1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/mutate.cpp b/src/mutate.cpp
@@ -53,7 +53,7 @@ class ConstantRecycler {
 
 inline SEXP constant_recycle(SEXP x, int n, const SymbolString& name) {
   if (Rf_inherits(x, "POSIXlt")) {
-    bad_col(name, "is of unsupported class POSIXlt");
+    bad_col(name, "is of unsupported class POSIXlt; please use POSIXct instead");
   }
   switch (TYPEOF(x)) {
   case INTSXP:
@@ -160,7 +160,7 @@ class MutateCallProxy {
     Rcpp::RObject first(get(indices));
 
     if (Rf_inherits(first, "POSIXlt")) {
-      bad_col(name, "is of unsupported class POSIXlt");
+      bad_col(name, "is of unsupported class POSIXlt; please use POSIXct instead");
     }
 
     if (Rf_inherits(first, "data.frame")) {
@@ -220,7 +220,7 @@ SEXP MutateCallProxy<NaturalDataFrame>::evaluate() {
   if (Rf_isNull(first)) return R_NilValue;
 
   if (Rf_inherits(first, "POSIXlt")) {
-    bad_col(name, "is of unsupported class POSIXlt");
+    bad_col(name, "is of unsupported class POSIXlt; please use POSIXct instead");
   }
 
   if (Rf_inherits(first, "data.frame")) {

diff --git a/tests/testthat/test-mutate.r b/tests/testthat/test-mutate.r
@@ -210,7 +210,7 @@ test_that("mutate fails on unsupported column type", {
   df <- data.frame(created = c("2014/1/1", "2014/1/2", "2014/1/2"))
   expect_error(
     mutate(df, date = strptime(created, "%Y/%m/%d")),
-    "Column `date` is of unsupported class POSIXlt",
+    "Column `date` is of unsupported class POSIXlt; please use POSIXct instead",
     fixed = TRUE
   )
 
@@ -220,7 +220,7 @@ test_that("mutate fails on unsupported column type", {
   )
   expect_error(
     mutate(group_by(df, g), date = strptime(created, "%Y/%m/%d")),
-    "Column `date` is of unsupported class POSIXlt",
+    "Column `date` is of unsupported class POSIXlt; please use POSIXct instead",
     fixed = TRUE
   )
 })
@@ -442,15 +442,15 @@ test_that("mutate forbids POSIXlt results (#670)", {
   expect_error(
     data.frame(time = "2014/01/01 10:10:10") %>%
       mutate(time = as.POSIXlt(time)),
-    "Column `time` is of unsupported class POSIXlt",
+    "Column `time` is of unsupported class POSIXlt; please use POSIXct instead",
     fixed = TRUE
   )
 
   expect_error(
     data.frame(time = "2014/01/01 10:10:10", a = 2) %>%
       group_by(a) %>%
       mutate(time = as.POSIXlt(time)),
-    "Column `time` is of unsupported class POSIXlt",
+    "Column `time` is of unsupported class POSIXlt; please use POSIXct instead",
     fixed = TRUE
   )
 })