getting closer

src/__tests__/book-screen.js

@@ -2,6 +2,7 @@ import React from 'react'
 import {
   render,
   screen,
+  act,
   waitForLoadingToFinish,
   userEvent,
   loginAsUser,
@@ -163,9 +164,12 @@ test('can edit a note', async () => {
   userEvent.type(notesTextarea, newNotes)
 
   // wait for the loading spinner to show up
-  await screen.findByLabelText(/loading/i, undefined, {timeout: 500})
+  await screen.findByLabelText(/loading/i)
   // wait for the loading spinner to go away
-  await waitForLoadingToFinish({timeout: 500})
+  await waitForLoadingToFinish()
+  // TODO: other tests fail when I remove this next line
+  // figure out why and remove it.
+  act(() => jest.advanceTimersByTime(1))
 
   expect(notesTextarea.value).toBe(newNotes)
 

src/components/__mocks__/profiler.js

@@ -0,0 +1,5 @@
+// we have this mock here so the profiler doesn't actually
+// attempt to send profile reports during tests.
+const Profiler = ({children}) => children
+
+export {Profiler}

src/setupTests.js

@@ -7,6 +7,9 @@ import * as usersDB from 'test/data/users'
 import * as listItemsDB from 'test/data/list-items'
 import * as booksDB from 'test/data/books'
 
+// we don't need the profiler in tests
+jest.mock('components/profiler')
+
 // set the location to the /list route as we auto-redirect users to that route
 window.history.pushState({}, 'Home page', '/list')
 

src/test/app-test-utils.js

@@ -1,4 +1,3 @@
-import {queryCache} from 'react-query'
 import {render as rtlRender, screen, waitFor} from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
 import * as auth from 'auth-provider'
@@ -37,9 +36,6 @@ async function loginAsUser(userProperties) {
 function waitForLoadingToFinish() {
   return waitFor(
     () => {
-      if (queryCache.isFetching) {
-        throw new Error('The react-query queryCache is still fetching')
-      }
       if (
         screen.queryAllByLabelText(/loading/i).length ||
         screen.queryAllByText(/loading/i).length