Skip to content

Commit

Permalink
Allow UTF-8 characters in changelog
Browse files Browse the repository at this point in the history
Testing Done:
Tests pass, except that sometimes they fail on travis because
sys.stdout.encoding.

Reviewed at https://rbcommons.com/s/twitter/r/1228/
  • Loading branch information
dturner-tw committed Oct 28, 2014
1 parent 63482d3 commit 3c91e34
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/python/pants/backend/jvm/tasks/jar_publish.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
from pants.ivy.bootstrapper import Bootstrapper
from pants.ivy.ivy import Ivy
from pants.util.dirutil import safe_mkdir, safe_open, safe_rmtree, touch
from pants.util.strutil import ensure_text


class PushDb(object):
Expand Down Expand Up @@ -959,8 +960,8 @@ def fingerprint(self, target, fingerprint_internal):
return sha.hexdigest()

def changelog(self, target, sha):
return self.scm.changelog(from_commit=sha,
files=target.sources_relative_to_buildroot())
return ensure_text(self.scm.changelog(from_commit=sha,
files=target.sources_relative_to_buildroot()))

def generate_ivysettings(self, ivy, publishedjars, publish_local=None):
if ivy.ivy_settings is None:
Expand Down

0 comments on commit 3c91e34

Please sign in to comment.