Merge pull request JetBrains#39 from benbalter/edu-rejects

THE BLACKLIST

.gitignore

@@ -1,2 +1,3 @@
 .DS_Store
 Gemfile.lock
+*.gem

.ruby-version

@@ -0,0 +1 @@
+2.0.0

lib/swot.rb

@@ -123,6 +123,13 @@ module Swot
     'vic.edu.au' => 1,
   }
 
+  # These are domains that snuck into the edu registry,
+  # but don't pass the education sniff test
+  # Note: domain must be a direct match
+  BLACKLIST = [
+    'si.edu',
+  ]
+
   class << self
 
     # Figure out if an email or domain belongs to academic institution.
@@ -135,7 +142,9 @@ def is_academic?(text)
         domain = get_domain(text)
         return false if domain.nil?
 
-        if ACADEMIC_TLDS[domain.tld]
+        if BLACKLIST.include? domain.name
+          false
+        elsif ACADEMIC_TLDS[domain.tld]
           true
         elsif match_academic_domain?(domain)
           true

swot.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |s|
   ]
   s.files = [
     ".document",
-    ".rbenv-version",
+    ".ruby-version",
     "CONTRIBUTING.md",
     "Gemfile",
     "LICENSE.txt",
@@ -7725,4 +7725,3 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<jeweler>, ["~> 1.8.3"])
   end
 end
-

test/test_swot.rb

@@ -58,4 +58,10 @@ class TestEmail < Test::Unit::TestCase
     assert_equal Swot::academic?('stanford.edu'), true
     assert_equal Swot::school_name('[email protected]'), "University of Strathclyde"
   end
+
+  should "fail blacklisted domains" do
+    ["si.edu", " si.edu ", "[email protected]"].each do |domain|
+      assert_equal false, Swot::is_academic?(domain), "#{domain} should be denied"
+    end
+  end
 end