Skip to content

Commit

Permalink
Move tonic into //flutter/third_party. (flutter#15895)
Browse files Browse the repository at this point in the history
Tonic used to be used by multiple consumers outside of Flutter Engine. Due to
this, it has an unnecessary abstraction layer as well as utilities duplicated in
FML and other engine subsystems. The sole user of Tonic is now the Flutter
Engine. It is intended that the Flutter Engine team now owns this subsystem,
remove unnecessary utilities and document the headers. This is the first step in
the transition. No history is being imported as the initial history was already
lost in the transition of this component to fuchsia.googlesource. As this
component was unmaintained there, I could see no additional value in importing
the history of the patches there.

No functional change. Just moved the repo from //third_party to
//flutter/third_party and updates GN refs.
  • Loading branch information
chinmaygarde authored Jan 26, 2020
1 parent 6fa1fcd commit 276481c
Show file tree
Hide file tree
Showing 101 changed files with 5,202 additions and 400 deletions.
3 changes: 0 additions & 3 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@ deps = {
# build. Eventually, we'll manage these dependencies together with Fuchsia
# and not have to specific specific hashes.

'src/third_party/tonic':
Var('fuchsia_git') + '/tonic' + '@' + '1a8ed9be2e2b56b32e888266d6db465d36012df4',

'src/third_party/benchmark':
Var('fuchsia_git') + '/third_party/benchmark' + '@' + 'a779ffce872b4c811beef482e18bd0b63626aa42',

Expand Down
61 changes: 61 additions & 0 deletions ci/licenses_golden/licenses_flutter
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ USED LICENSES:

====================================================================================================
LIBRARY: engine
LIBRARY: tonic
LIBRARY: txt
ORIGIN: ../../../flutter/LICENSE
TYPE: LicenseType.bsd
Expand Down Expand Up @@ -1122,6 +1123,66 @@ FILE: ../../../flutter/shell/version/version.cc
FILE: ../../../flutter/shell/version/version.h
FILE: ../../../flutter/sky/packages/flutter_services/lib/empty.dart
FILE: ../../../flutter/sky/tools/roll/patches/chromium/android_build.patch
FILE: ../../../flutter/third_party/tonic/common/build_config.h
FILE: ../../../flutter/third_party/tonic/common/log.cc
FILE: ../../../flutter/third_party/tonic/common/log.h
FILE: ../../../flutter/third_party/tonic/common/macros.h
FILE: ../../../flutter/third_party/tonic/converter/dart_converter.cc
FILE: ../../../flutter/third_party/tonic/converter/dart_converter.h
FILE: ../../../flutter/third_party/tonic/dart_args.h
FILE: ../../../flutter/third_party/tonic/dart_binding_macros.h
FILE: ../../../flutter/third_party/tonic/dart_class_library.cc
FILE: ../../../flutter/third_party/tonic/dart_class_library.h
FILE: ../../../flutter/third_party/tonic/dart_class_provider.cc
FILE: ../../../flutter/third_party/tonic/dart_class_provider.h
FILE: ../../../flutter/third_party/tonic/dart_library_natives.cc
FILE: ../../../flutter/third_party/tonic/dart_library_natives.h
FILE: ../../../flutter/third_party/tonic/dart_list.cc
FILE: ../../../flutter/third_party/tonic/dart_list.h
FILE: ../../../flutter/third_party/tonic/dart_message_handler.cc
FILE: ../../../flutter/third_party/tonic/dart_message_handler.h
FILE: ../../../flutter/third_party/tonic/dart_microtask_queue.cc
FILE: ../../../flutter/third_party/tonic/dart_microtask_queue.h
FILE: ../../../flutter/third_party/tonic/dart_persistent_value.cc
FILE: ../../../flutter/third_party/tonic/dart_persistent_value.h
FILE: ../../../flutter/third_party/tonic/dart_state.cc
FILE: ../../../flutter/third_party/tonic/dart_state.h
FILE: ../../../flutter/third_party/tonic/dart_wrappable.cc
FILE: ../../../flutter/third_party/tonic/dart_wrappable.h
FILE: ../../../flutter/third_party/tonic/dart_wrapper_info.h
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader.cc
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader.h
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader_fuchsia.cc
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader_posix.cc
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader_win.cc
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/eintr_wrapper.h
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/file.cc
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/file.h
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/path.h
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/path_posix.cc
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/path_win.cc
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/portable_unistd.h
FILE: ../../../flutter/third_party/tonic/logging/dart_error.cc
FILE: ../../../flutter/third_party/tonic/logging/dart_error.h
FILE: ../../../flutter/third_party/tonic/logging/dart_invoke.cc
FILE: ../../../flutter/third_party/tonic/logging/dart_invoke.h
FILE: ../../../flutter/third_party/tonic/parsers/packages_map.cc
FILE: ../../../flutter/third_party/tonic/parsers/packages_map.h
FILE: ../../../flutter/third_party/tonic/platform/platform_utils.h
FILE: ../../../flutter/third_party/tonic/platform/platform_utils_posix.cc
FILE: ../../../flutter/third_party/tonic/platform/platform_utils_win.cc
FILE: ../../../flutter/third_party/tonic/scopes/dart_api_scope.h
FILE: ../../../flutter/third_party/tonic/scopes/dart_isolate_scope.cc
FILE: ../../../flutter/third_party/tonic/scopes/dart_isolate_scope.h
FILE: ../../../flutter/third_party/tonic/typed_data/dart_byte_data.cc
FILE: ../../../flutter/third_party/tonic/typed_data/dart_byte_data.h
FILE: ../../../flutter/third_party/tonic/typed_data/float32_list.h
FILE: ../../../flutter/third_party/tonic/typed_data/float64_list.h
FILE: ../../../flutter/third_party/tonic/typed_data/int32_list.h
FILE: ../../../flutter/third_party/tonic/typed_data/typed_list.cc
FILE: ../../../flutter/third_party/tonic/typed_data/typed_list.h
FILE: ../../../flutter/third_party/tonic/typed_data/uint16_list.h
FILE: ../../../flutter/third_party/tonic/typed_data/uint8_list.h
FILE: ../../../flutter/third_party/txt/src/txt/platform.cc
FILE: ../../../flutter/third_party/txt/src/txt/platform.h
FILE: ../../../flutter/third_party/txt/src/txt/platform_android.cc
Expand Down
Loading

0 comments on commit 276481c

Please sign in to comment.