Naming suggestions #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Removed all references to the word "ioctl" in the public interface, because "ioctl" is by nature an implementation detail. Suggesting "vmmctl" as a more generic name that collects together all interfaces that exert control over a vmm 2) Removed the "*::interface" namespace in favor of exposing vmmctl namespace to users of the library, and using vmmctl::details for internal development 3) Suggesting we replace the top level "host::" namespace with "vmmctl::". Then microV could also have a "vmctl" namespaces for working with VM's Signed-off-by: JaredWright <[email protected]>
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all references to the word "ioctl" in the public interface,
because "ioctl" is by nature an implementation detail. Suggesting
"vmmctl" as a more generic name that collects together all interfaces
that exert control over a vmm
Removed the "*::interface" namespace in favor of exposing vmmctl
namespace to users of the library, and using vmmctl::details for
internal development
Suggesting we replace the top level "host::" namespace with
"vmmctl::". Then microV could also have a "vmctl" namespaces for working
with VM's
Signed-off-by: JaredWright [email protected]
This change is