Merge pull request shipshapecode#204 from pzuraq/adds-option-to-speci…

…fy-body-element Adds option to specify body element
richard-maya · Dec 2, 2016 · 3d7119e · 3d7119e
2 parents 74256cc + 4de1f5c
commit 3d7119e
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 28 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "tether",
-  "version": "1.3.9",
+  "version": "1.4.0",
   "homepage": "http://github.hubspot.com/tether",
   "authors": [
     "Zack Bloom <[email protected]>",

diff --git a/dist/js/tether.js b/dist/js/tether.js
@@ -1,4 +1,4 @@
-/*! tether 1.3.9 */
+/*! tether 1.4.0 */
 
 (function(root, factory) {
   if (typeof define === 'function' && define.amd) {
@@ -1247,20 +1247,24 @@ var TetherClass = (function (_Evented) {
       }
 
       if (!moved) {
-        var offsetParentIsBody = true;
-        var currentNode = this.element.parentNode;
-        while (currentNode && currentNode.nodeType === 1 && currentNode.tagName !== 'BODY') {
-          if (getComputedStyle(currentNode).position !== 'static') {
-            offsetParentIsBody = false;
-            break;
-          }
+        if (this.options.bodyElement) {
+          this.options.bodyElement.appendChild(this.element);
+        } else {
+          var offsetParentIsBody = true;
+          var currentNode = this.element.parentNode;
+          while (currentNode && currentNode.nodeType === 1 && currentNode.tagName !== 'BODY') {
+            if (getComputedStyle(currentNode).position !== 'static') {
+              offsetParentIsBody = false;
+              break;
+            }
 
-          currentNode = currentNode.parentNode;
-        }
+            currentNode = currentNode.parentNode;
+          }
 
-        if (!offsetParentIsBody) {
-          this.element.parentNode.removeChild(this.element);
-          this.element.ownerDocument.body.appendChild(this.element);
+          if (!offsetParentIsBody) {
+            this.element.parentNode.removeChild(this.element);
+            this.element.ownerDocument.body.appendChild(this.element);
+          }
         }
       }
 

diff --git a/dist/js/tether.min.js b/dist/js/tether.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tether",
-  "version": "1.3.9",
+  "version": "1.4.0",
   "description": "A client-side library to make absolutely positioned elements attach to elements in the page efficiently.",
   "authors": [
     "Zack Bloom <[email protected]>",

diff --git a/src/js/tether.js b/src/js/tether.js
@@ -759,20 +759,24 @@ class TetherClass extends Evented {
     }
 
     if (!moved) {
-      let offsetParentIsBody = true;
-      let currentNode = this.element.parentNode;
-      while (currentNode && currentNode.nodeType === 1 && currentNode.tagName !== 'BODY') {
-        if (getComputedStyle(currentNode).position !== 'static') {
-          offsetParentIsBody = false;
-          break;
-        }
+      if (this.options.bodyElement) {
+        this.options.bodyElement.appendChild(this.element);
+      } else {
+        let offsetParentIsBody = true;
+        let currentNode = this.element.parentNode;
+        while (currentNode && currentNode.nodeType === 1 && currentNode.tagName !== 'BODY') {
+          if (getComputedStyle(currentNode).position !== 'static') {
+            offsetParentIsBody = false;
+            break;
+          }
 
-        currentNode = currentNode.parentNode;
-      }
+          currentNode = currentNode.parentNode;
+        }
 
-      if (!offsetParentIsBody) {
-        this.element.parentNode.removeChild(this.element);
-        this.element.ownerDocument.body.appendChild(this.element);
+        if (!offsetParentIsBody) {
+          this.element.parentNode.removeChild(this.element);
+          this.element.ownerDocument.body.appendChild(this.element);
+        }
       }
     }