Merge pull request socketio#983 from GICodeWarrior/parser-recursion

Fix infinite recursion in Websocket parsers.
richardriman · Aug 6, 2012 · 8ca8990 · 8ca8990
2 parents 4164e3b + c218468
commit 8ca8990
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/transports/websocket/hybi-07-12.js b/lib/transports/websocket/hybi-07-12.js
@@ -464,7 +464,7 @@ Parser.prototype.add = function(data) {
     var bufferForHandler = this.expectBuffer;
     this.expectBuffer = null;
     this.expectOffset = 0;
-    this.expectHandler.call(this, bufferForHandler);
+    process.nextTick(this.expectHandler.bind(this, bufferForHandler));
   }
 }
 

diff --git a/lib/transports/websocket/hybi-16.js b/lib/transports/websocket/hybi-16.js
@@ -463,7 +463,7 @@ Parser.prototype.add = function(data) {
     var bufferForHandler = this.expectBuffer;
     this.expectBuffer = null;
     this.expectOffset = 0;
-    this.expectHandler.call(this, bufferForHandler);
+    process.nextTick(this.expectHandler.bind(this, bufferForHandler));
   }
 }