[runtime] Miscellaneous printf cleanup (dotnet#2177)

Done to unblock the externs. More work should probably be done, see mono/mono#18580.

Co-authored-by: Ryan Lucia <[email protected]>

src/mono/mono/eglib/glib.h

@@ -770,7 +770,7 @@ typedef enum {
 
 G_ENUM_FUNCTIONS (GLogLevelFlags)
 
-void           g_printv               (const gchar *format, va_list args);
+gint           g_printv               (const gchar *format, va_list args);
 void           g_print                (const gchar *format, ...);
 void           g_printerr             (const gchar *format, ...);
 GLogLevelFlags g_log_set_always_fatal (GLogLevelFlags fatal_mask);

src/mono/mono/eglib/goutput.c

@@ -57,19 +57,23 @@ g_assert_abort (void)
 		abort ();
 }
 
-void
+gint
 g_printv (const gchar *format, va_list args)
 {
 	char *msg;
+	int ret;
 
-	if (g_vasprintf (&msg, format, args) < 0)
-		return;
+	ret = g_vasprintf (&msg, format, args);
+	if (ret < 0)
+		return -1;
 
 	if (!stdout_handler)
 		stdout_handler = default_stdout_handler;
 
 	stdout_handler (msg);
 	g_free (msg);
+
+	return ret;
 }
 
 void
@@ -81,6 +85,19 @@ g_print (const gchar *format, ...)
 	va_end (args);
 }
 
+gint
+g_printf (gchar const *format, ...)
+{
+	va_list args;
+	gint ret;
+
+	va_start (args, format);
+	ret = g_printv (format, args);
+	va_end (args);
+
+	return ret;
+}
+
 void
 g_printerr (const gchar *format, ...)
 {

src/mono/mono/eglib/gstr.c

@@ -610,19 +610,6 @@ g_strchomp (gchar *str)
 	return str;
 }
 
-gint
-g_printf(gchar const *format, ...)
-{
-	va_list args;
-	gint ret;
-
-	va_start(args, format);
-	ret = vprintf(format, args);
-	va_end(args);
-
-	return ret;
-}
-
 gint
 g_fprintf(FILE *file, gchar const *format, ...)
 {