Add a few IdnMapping tests (dotnet/corefx#28797)

Validate that we get the same string object back when we expect to. Commit migrated from dotnet/corefx@b3ba359
richardsonjf · Apr 5, 2018 · d468d43 · d468d43
1 parent 5c05dbf
commit d468d43
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/libraries/System.Globalization.Extensions/tests/IdnMapping/IdnMappingGetAsciiTests.cs b/src/libraries/System.Globalization.Extensions/tests/IdnMapping/IdnMappingGetAsciiTests.cs
@@ -84,6 +84,17 @@ public void GetAscii(string unicode, int index, int count, string expected)
             Assert.Equal(expected, new IdnMapping().GetAscii(unicode, index, count));
         }
 
+        [SkipOnTargetFramework(~TargetFrameworkMonikers.Netcoreapp, "Optimization in .NET Core")]
+        [Theory]
+        [InlineData("www.microsoft.com")]
+        [InlineData("bing.com")]
+        public void GetAscii_NoTranslationNeeded_ResultIsSameObjectAsInput(string input)
+        {
+            Assert.Same(input, new IdnMapping().GetAscii(input));
+            Assert.NotSame(input, new IdnMapping().GetAscii(input.Substring(1)));
+            Assert.NotSame(input, new IdnMapping().GetAscii(input.Substring(0, input.Length - 1)));
+        }
+
         [Fact]
         public void TestGetAsciiWithDot()
         {

diff --git a/src/libraries/System.Globalization.Extensions/tests/IdnMapping/IdnMappingGetUnicodeTests.cs b/src/libraries/System.Globalization.Extensions/tests/IdnMapping/IdnMappingGetUnicodeTests.cs
@@ -59,6 +59,17 @@ public void GetUnicode(string ascii, int index, int count, string expected)
             Assert.Equal(expected, new IdnMapping().GetUnicode(ascii, index, count));
         }
 
+        [SkipOnTargetFramework(~TargetFrameworkMonikers.Netcoreapp, "Optimization in .NET Core")]
+        [Theory]
+        [InlineData("www.microsoft.com")]
+        [InlineData("bing.com")]
+        public void GetUnicode_NoTranslationNeeded_ResultIsSameObjectAsInput(string input)
+        {
+            Assert.Same(input, new IdnMapping().GetUnicode(input));
+            Assert.NotSame(input, new IdnMapping().GetUnicode(input.Substring(1)));
+            Assert.NotSame(input, new IdnMapping().GetUnicode(input.Substring(0, input.Length - 1)));
+        }
+
         public static IEnumerable<object[]> GetUnicode_Invalid_TestData()
         {
             // Ascii is null