Apply review comments

rickhohler · Dec 1, 2020 · b55d432 · b55d432
1 parent 1db73c6
commit b55d432
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/ctap/storage.rs b/src/ctap/storage.rs
@@ -387,7 +387,8 @@ impl PersistentStore {
         Ok(self.store.insert(key::MIN_PIN_LENGTH, &[min_pin_length])?)
     }
 
-    /// Returns a list of RP IDs that used to check if reading the minimum PIN length is allowed.
+    /// Returns the list of RP IDs that are used to check if reading the minimum PIN length is
+    /// allowed.
     #[cfg(feature = "with_ctap2_1")]
     pub fn _min_pin_length_rp_ids(&self) -> Result<Vec<String>, Ctap2StatusCode> {
         let rp_ids = self
@@ -400,7 +401,7 @@ impl PersistentStore {
         Ok(rp_ids.unwrap_or(vec![]))
     }
 
-    /// Set a list of RP IDs that used to check if reading the minimum PIN length is allowed.
+    /// Sets the list of RP IDs that are used to check if reading the minimum PIN length is allowed.
     #[cfg(feature = "with_ctap2_1")]
     pub fn _set_min_pin_length_rp_ids(
         &mut self,

diff --git a/src/ctap/storage/key.rs b/src/ctap/storage/key.rs
@@ -104,8 +104,7 @@ make_partition! {
 
     /// The encryption and hmac keys.
     ///
-    /// This entry is always present. It is generated at startup if absent. This is not a persistent
-    /// key because its value should change after a CTAP reset.
+    /// This entry is always present. It is generated at startup if absent.
     MASTER_KEYS = 2046;
 
     /// The global signature counter.