Skip to content

Commit

Permalink
Replace webpack-dev-middleware with our own improved version.
Browse files Browse the repository at this point in the history
  • Loading branch information
sorccu committed Apr 21, 2014
1 parent 1e18c99 commit c9043dd
Show file tree
Hide file tree
Showing 3 changed files with 115 additions and 19 deletions.
120 changes: 105 additions & 15 deletions lib/middleware/webpack.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,112 @@
var webpackMiddleware = require('webpack-dev-middleware')
var path = require('path')
var url = require('url')

var webpack = require('webpack')
var mime = require('mime')
var Promise = require('bluebird')
var _ = require('lodash')
var MemoryOutputFileSystem = require('webpack/lib/MemoryOutputFileSystem')
var MemoryInputFileSystem =
require('webpack/node_modules/enhanced-resolve/lib/MemoryInputFileSystem')

var webpackOptions = require('../../webpack.config.js')
var logger = require('../util/logger')
var lifecycle = require('../util/lifecycle')
var globalOptions = require('../../webpack.config')

var overrideOptions = {
debug: true,
devtool: 'eval'
}
// Similar to webpack-dev-middleware, but integrates with our custom
// lifecycle, behaves more like normal express middleware, and removes
// all unnecessary features.
module.exports = function(options) {
var log = logger.createLogger('middleware:webpack')
options = _.defaults(options || {}, globalOptions)

var storage = Object.create(null)
var fs = new MemoryInputFileSystem(storage)

var compiler = webpack(options)
compiler.outputFileSystem = new MemoryOutputFileSystem(storage)

var valid = false
var queue = []

var finalOptions = _.assign(webpackOptions, overrideOptions)
log.info('Creating bundle')
var watching = compiler.watch(options.watchDelay, function(err) {
if (err) {
log.fatal('Webpack had an error', err.stack)
lifecycle.fatal()
}
})

module.exports = webpackMiddleware(webpack(finalOptions), {
noInfo: false,
quiet: false,
lazy: false,
publicPath: '/static/build/',
stats: {
colors: true
lifecycle.observe(function() {
watching.watcher.close()
})

function doneListener(stats) {
process.nextTick(function() {
if (valid) {
log.info(stats.toString(options.stats))

if (stats.hasErrors()) {
log.error('Bundle has errors')
}
else if (stats.hasWarnings()) {
log.warn('Bundle has warnings')
}
else {
log.info('Bundle is now valid')
}

queue.forEach(function(resolver) {
resolver.resolve()
})
}
})

valid = true
}
})

function invalidate() {
if (valid) {
log.info('Bundle is now invalid')
valid = false
}
}

compiler.plugin('done', doneListener)
compiler.plugin('invalid', invalidate)
compiler.plugin('compile', invalidate)

function bundle() {
if (valid) {
return Promise.resolve()
}
else {
log.info('Waiting for bundle to finish')
var resolver = Promise.defer()
queue.push(resolver)
return resolver.promise
}
}

return function(req, res, next) {
var parsedUrl = url.parse(req.url)

var target = path.join(
compiler.outputPath
, parsedUrl.pathname
)

bundle()
.then(function() {
try {
var body = fs.readFileSync(target)
res.set('Content-Type', mime.lookup(target))
res.end(body)
}
catch (err) {
return next()
}
})
.catch(next)
}
}
11 changes: 7 additions & 4 deletions lib/roles/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ module.exports = function(options) {
io.set('browser client', false)
io.set('transports', ['websocket'])

if (!options.disableWatch) {
app.use('/static/build', webpack({
debug: true
, devtool: 'eval'
}))
}

app.use('/static/bower_components',
express.static(pathutil.resource('bower_components')))
app.use('/static/data', express.static(pathutil.resource('data')))
Expand All @@ -54,10 +61,6 @@ module.exports = function(options) {
app.use(express.favicon(pathutil.resource(
'bower_components/stf-graphics/logo/exports/STF-128.png')))

if (!options.disableWatch) {
app.use(webpack)
}

app.use(express.cookieParser(options.secret))
app.use(express.cookieSession({
key: options.ssid
Expand Down
3 changes: 3 additions & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ module.exports = {
, publicPath: '/static/build/'
, filename: 'bundle.js'
}
, stats: {
colors: true
}
, resolve: {
modulesDirectories: [
pathutil.resource('bower_components')
Expand Down

0 comments on commit c9043dd

Please sign in to comment.