SAK-31345 Fix Hiding/unhiding "Site Info" (sakaiproject#3254)

Add check to see if SITE_VISIT is in permissions list before trying to remove it.
rifqioe · Oct 13, 2016 · 3592e97 · 3592e97
1 parent 85d1576
commit 3592e97
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...order/tool/src/java/org/sakaiproject/site/tool/helper/order/impl/SitePageEditHandler.java b/...order/tool/src/java/org/sakaiproject/site/tool/helper/order/impl/SitePageEditHandler.java
@@ -598,7 +598,9 @@ private boolean pageVisibilityHelper(String pageId, boolean visible, boolean ena
             if (!(permissions.isEmpty())) {
                 // We never change SITE_UPD at all.
                 permissions.remove(SITE_UPD);
-                permissions.remove(SITE_VISIT);
+                if (permissions.indexOf(SITE_VISIT) > 0) {
+                	permissions.remove(SITE_VISIT);
+                }
                 Set<Role> roles = getRolesWithout(authzGroup, SITE_UPD);