GEODE-10171: Update versioning for no-op operations (apache#7527)

Modified lrem to not update versioning if nothing was removed from the list.
ringles · Mar 31, 2022 · fb17fe4 · fb17fe4
1 parent 59af2c8
commit fb17fe4
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java b/geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
@@ -221,17 +221,18 @@ public List<byte[]> lrange(int start, int stop) {
    */
   public int lrem(int count, byte[] element, Region<RedisKey, RedisData> region, RedisKey key) {
     List<Integer> removedIndexes;
-    byte version;
+    byte newVersion;
     synchronized (this) {
       removedIndexes = elementList.remove(element, count);
-      version = incrementAndGetVersion();
-    }
+      if (removedIndexes.isEmpty()) {
+        return 0;
+      }
 
-    if (!removedIndexes.isEmpty()) {
-      storeChanges(region, key,
-          new RemoveElementsByIndex(version, removedIndexes));
+      newVersion = incrementAndGetVersion();
     }
 
+    storeChanges(region, key,
+        new RemoveElementsByIndex(newVersion, removedIndexes));
     return removedIndexes.size();
   }