Enforce narwhal header timestamp monotonic with respect to it's paren…

…ts (MystenLabs#10145)
ritic89 · Mar 30, 2023 · bce0c14 · bce0c14
1 parent e76948d
commit bce0c14
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/narwhal/primary/src/primary.rs b/narwhal/primary/src/primary.rs
@@ -810,6 +810,10 @@ impl PrimaryReceiverHandler {
                 parent.round() + 1 == header.round(),
                 DagError::HeaderHasInvalidParentRoundNumbers(header.digest())
             );
+            ensure!(
+                header.created_at() >= parent.header().created_at(),
+                DagError::HeaderHasInvalidParentTimestamp(header.digest())
+            );
             ensure!(
                 parent_authorities.insert(parent.header().author()),
                 DagError::HeaderHasDuplicateParentAuthorities(header.digest())

diff --git a/narwhal/types/src/error.rs b/narwhal/types/src/error.rs
@@ -57,6 +57,9 @@ pub enum DagError {
     #[error("Header {0} has parents with invalid round numbers")]
     HeaderHasInvalidParentRoundNumbers(HeaderDigest),
 
+    #[error("Header {0} has parents with invalid timestamp")]
+    HeaderHasInvalidParentTimestamp(HeaderDigest),
+
     #[error("Header {0} has more than one parent certificate with the same authority")]
     HeaderHasDuplicateParentAuthorities(HeaderDigest),