Skip to content

Commit

Permalink
fix bad property in animation at load
Browse files Browse the repository at this point in the history 
When an animation tries to key a property that is not supported on the object, the runtime fails the load op. This seemed like a good idea at the time but it affects compatibility as we could remove keyed properties or have new ones that old runtimes do not understand. The runtime should just prune these from the keyed list, which is what this PR does and adds a test with a file that tries to key the old feather value on the shape paint (which we've now removed in favor of one on the feather object itself).

https://2dimensions.slack.com/archives/C07VD44ASE5/p1737664856604919

Diffs=
4c1da5310e fix bad property in animation at load (#8927)
  • Loading branch information
mjtalbot committed Jan 29, 2025
1 parent 3fc9859 commit 44a5fd9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
94fc10095cbf8691fdfa908d6e0208473f869467
4c1da5310e149c7ea9eeb6ff15cbb202d22aef6d
2 changes: 1 addition & 1 deletion submodules/rive-runtime
Submodule rive-runtime updated 5 files
+2 −0 .gitignore
+1 −1 .rive_head
+7 −3 src/animation/keyed_object.cpp
+ − tests/unit_tests/assets/magic_alley_db_reduced_export.riv
+19 −19 tests/unit_tests/runtime/file_test.cpp

0 comments on commit 44a5fd9

Please sign in to comment.