Implement -no-xwayland flag

[novakne]

Add a cli flag to river command to disable xwayland at runtime if river has been build with xwayland support.

It does works as expected right now but a few questions, no sure how types should be handled, for e.g. xwayland_override_redirect: if (build_options.xwayland) *wlr.SceneTree else void,?
And some others things that I'll write in a review to be more clear.

closes #913

[novakne]

Well not a review since the code is not in the changed files...

Not sure if an if (server.runtime_xwayland) statement is needed here or maybe an assert
https://github.com/riverwm/river/blob/master/river/Cursor.zig#L938-L940

Same here, not sure if it would cause any problem to let it like that
https://github.com/riverwm/river/blob/master/river/Root.zig#L131

[ifreund]

Thanks for working on this!

Not sure if an if (server.runtime_xwayland) statement is needed here or maybe an assert
https://github.com/riverwm/river/blob/master/river/Cursor.zig#L938-L940

An assert(server.xwayland != null); would be good.

Same here, not sure if it would cause any problem to let it like that
https://github.com/riverwm/river/blob/master/river/Root.zig#L131

I think we should make this have type ?*wlr.SceneTree and initialize it to null if xwayland is disabled at runtime.

[novakne]

@ifreund any preference, when needed, between:

if (build_options.xwayland and server.xwayland != null) {
    server.xwayland.?.<function>
}

// or 
if (build_options.xwayland) {
    if (server.xwayland) |xwayland| {
        xwayland.<function>
    }
}

[ifreund]

@ifreund any preference, when needed, between:

if (build_options.xwayland and server.xwayland != null) {
    server.xwayland.?.<function>
}

// or 
if (build_options.xwayland) {
    if (server.xwayland) |xwayland| {
        xwayland.<function>
    }
}

I prefer the second one :)

[novakne]

Should be better, even if I'm not super fan of the xwayland_override_redirect code

[ifreund]

Just a bit more minor style cleanup then this should be ready to land :)

[ifreund]

Thanks for the patch! I ended up changing my mind on the xwayland_override_redirect scene tree thing. I think it's cleaner to just create it regardless of whether -no-xwayland is passed or not, the amount of memory "wasted" is insignificant.

[ifreund]

Well, I've failed to trick github into saying this PR got merged. Codeberg's manually merged feature is so much nicer...

[novakne]

Well, I've failed to trick github into saying this PR got merged. Codeberg's manually merged feature is so much nicer...

Soon, we're free :)
I also found this morning that is way nicer to get a patch or diff from a PR on codeberg, which is really cool!