preserve global variables with local, not copy/restore

rjbs · Jan 7, 2023 · 3e987aa · 3e987aa
1 parent 8bb2c23
commit 3e987aa
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/lib/Test/Deep.pm b/lib/Test/Deep.pm
@@ -79,20 +79,15 @@ while (my ($pkg, $name) = splice @constructors, 0, 2)
   my $file = "$full_pkg.pm";
   $file =~ s#::#/#g;
   my $sub = sub {
-
-    # We might be in the middle of testing one of the globals
-    # that require() overwrites. To simplify test authorship,
-    # we put those overwritten values back below.
-    my $dollar_at = $@;
-    my $dollar_bang = $!;
-    my $dollar_e = $^E;
+    # We might be in the middle of testing one of the globals that require()
+    # overwrites. To simplify test authorship, we'll preserve any existing
+    # value.
+    local $@;
+    local $!;
+    local $^E;
 
     require $file;
 
-    $@ = $dollar_at;
-    $! = $dollar_bang;
-    $^E = $dollar_e;
-
     return $full_pkg->new(@_);
   };
   {