Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readdcw: Fix unwatching at the same time as incoming event #126

Closed
wants to merge 12 commits into from
Closed

readdcw: Fix unwatching at the same time as incoming event #126

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
282ae65
Try to reproduce "another re/unwatching operation" problem
imsodin Aug 27, 2017
e501009
fix
imsodin Aug 27, 2017
66f1eea
fix2
imsodin Aug 27, 2017
c48e15b
fix3
imsodin Aug 27, 2017
011ad62
fix4
imsodin Aug 27, 2017
31f9547
fix5
imsodin Aug 27, 2017
e8f7398
fix6
imsodin Aug 27, 2017
4abd3ce
activate debug logging
imsodin Aug 27, 2017
ab5b9fb
add debug logging on watch
imsodin Aug 27, 2017
20d8975
Use absolute path in test watchers
imsodin Aug 27, 2017
5792fac
Try the other way around
imsodin Aug 27, 2017
3d5a94e
commit -a is evil
imsodin Aug 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@imsodin
imsodin committed Aug 27, 2017
commit e501009c1e545e63a29eeb668e868a9e826e1fbe
9 changes: 7 additions & 2 deletions watcher_readdcw_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@

package notify

import "testing"
import (
"filepath"
"os"
"testing"
"time"
)

// TODO(ppknap) : remove notify.Create event.
func rcreate(w *W, path string) WCase {
Expand Down Expand Up @@ -70,7 +75,7 @@ func TestWatcherReaddcwUnwatchChangeRace(t *testing.T) {
w := NewWatcherTest(t, "testdata/vfs.txt", All)
defer w.Close()

triggerFile = filepath.Join(w.root, "trigger")
triggerFile := filepath.Join(w.root, "trigger")
os.Create(triggerFile)
time.Sleep(time.Duration(100) * time.Millisecond)

Expand Down