Revert "Handle pointers that are now integers in Go 1.10 (fixes #135)" #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interesting, I did not follow changes in Go recently. Out of curiosity, do you have a reference for the change you mention? |
|
I don't, I just noticed that 1.10 RC1 gave me the opposite problem that I fixed for 1.10 beta-something... But we should have that noted here somewhere so let me dig a little |
|
I think the latest relevant change is golang/go@d162a297ed I can't say I fully understand it, but I feel like what happened was the initial breakage in 1.10 beta1 was inadvertent and I was premature in fixing it... It would be spectacular if this changed again after 1.10 rc1 |
|
@calmh Could you rebase with master please? |
|
Done. Travis failure looks unrelated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thing I did to fix compatibility for Go 1.10 has been changed again on the Go tree since. To actually build with go1.10rc1 we need to revert my thing. Sorry.
This reverts commit ff2d4d2.