all: do assorted cleanup, make tests pass #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
josharian
commented
Dec 13, 2022
josharian
commented
- add go.sum
- check error from os.RemoveAll in test
- make NewNotifyTest and friends handle cleanup
- use t.TempDir instead of ioutil.TempDir
- use os.SameFile to test for path equality
- be more careful about cleaning up test trees
- remove ioutil
|
This is work done in preparation for #212. I wanted to get all the tests passing before I started altering things, and got sidetracked by stranded test files and code modernization, and one thing led to another, and, well, there's a large PR. Sorry about that. |
rjeczalik
approved these changes
Dec 13, 2022
|
@josharian Can you please squash all the commits into one? |
|
Each commit is conceptually standalone, with an appropriate commit message...but if you would prefer, yes, I can squash them. I just wanted to confirm first. :) |
Add go.sum to placate cmd/go. Check error from os.RemoveAll in test. Make NewNotifyTest and friends handle cleanup. This way the callers don't need to manage it. It is also more robust in the face of test failure, and thus less likely to strand testdata test files. Use t.TempDir instead of ioutil.TempDir. Use os.SameFile to test for path equality. On macOS, the temp dir is located in /var, which can also have path /private/var. Make the tests resilient to changes in the exact path name. With this fix, all tests now pass locally on macOS. Be more careful about cleaning up test trees. Fatalf calls runtime.Goexit, which doesn't run deferred funcs. Remove the defer and just call RemoveAll directly. This should help prevent stranded testdata dirs on test failure. Remove ioutil. It is deprecated.
|
OK, commits squashed down to one. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.