Merge branch 'feature/requests_exceptions' into develop

pycoingecko/api.py

@@ -22,6 +22,10 @@ def __request(self, url):
         # print(url)
         try:
             response = self.session.get(url, timeout=self.request_timeout)
+        except requests.exceptions.RequestException:
+            raise
+
+        try:
             response.raise_for_status()
             content = json.loads(response.content.decode('utf-8'))
             return content
@@ -33,8 +37,7 @@ def __request(self, url):
             # if no json
             except json.decoder.JSONDecodeError:
                 pass
-            # except UnboundLocalError as e:
-            #    pass
+
             raise
 
     def __api_url_params(self, api_url, params, api_url_has_params=False):

tests/test_api.py

@@ -1,13 +1,20 @@
 import pytest
+import requests.exceptions
 import responses
 import unittest
 import unittest.mock as mock
 
 from pycoingecko import CoinGeckoAPI
 from requests.exceptions import HTTPError
 
+
 class TestWrapper(unittest.TestCase):
 
+    @responses.activate
+    def test_connection_error(self):
+        with pytest.raises(requests.exceptions.ConnectionError):
+            CoinGeckoAPI().ping()
+
     @responses.activate
     def test_failed_ping(self):
         # Arrange