Bug 1231378 - part 2 - Fix uninitialized members of classes in dom/*,…

… r=smaug
rlr · Jan 12, 2016 · 83b88d3 · 83b88d3
1 parent 8ed4c36
commit 83b88d3
Show file tree

Hide file tree

Showing 22 changed files with 118 additions and 17 deletions.
diff --git a/dom/alarm/AlarmHalService.h b/dom/alarm/AlarmHalService.h
@@ -33,6 +33,10 @@ class AlarmHalService : public nsIAlarmHalService,
   NS_DECL_ISUPPORTS
   NS_DECL_NSIALARMHALSERVICE
 
+  AlarmHalService()
+    : mAlarmEnabled(false)
+  {}
+
   void Init();
 
   static already_AddRefed<AlarmHalService> GetInstance();

diff --git a/dom/broadcastchannel/BroadcastChannelChild.cpp b/dom/broadcastchannel/BroadcastChannelChild.cpp
@@ -27,7 +27,8 @@ namespace dom {
 using namespace workers;
 
 BroadcastChannelChild::BroadcastChannelChild(const nsACString& aOrigin)
-  : mActorDestroyed(false)
+  : mBC(nullptr)
+  , mActorDestroyed(false)
 {
   CopyUTF8toUTF16(aOrigin, mOrigin);
 }

diff --git a/dom/datastore/DataStoreService.cpp b/dom/datastore/DataStoreService.cpp
@@ -79,6 +79,8 @@ class DataStoreInfo
                 const nsAString& aManifestURL,
                 bool aReadOnly,
                 bool aEnabled)
+    : mReadOnly(true)
+    , mEnabled(false)
   {
     Init(aName, aOriginURL, aManifestURL, aReadOnly, aEnabled);
   }

diff --git a/dom/fetch/InternalRequest.cpp b/dom/fetch/InternalRequest.cpp
@@ -86,7 +86,6 @@ InternalRequest::InternalRequest(const InternalRequest& aOther)
   , mForceOriginHeader(aOther.mForceOriginHeader)
   , mPreserveContentCodings(aOther.mPreserveContentCodings)
   , mSameOriginDataURL(aOther.mSameOriginDataURL)
-  , mSandboxedStorageAreaURLs(aOther.mSandboxedStorageAreaURLs)
   , mSkipServiceWorker(aOther.mSkipServiceWorker)
   , mSynchronous(aOther.mSynchronous)
   , mUnsafeRequest(aOther.mUnsafeRequest)

diff --git a/dom/fetch/InternalRequest.h b/dom/fetch/InternalRequest.h
@@ -91,6 +91,7 @@ class InternalRequest final
   explicit InternalRequest()
     : mMethod("GET")
     , mHeaders(new InternalHeaders(HeadersGuardEnum::None))
+    , mContentPolicyType(nsIContentPolicy::TYPE_FETCH)
     , mReferrer(NS_LITERAL_STRING(kFETCH_CLIENT_REFERRER_STR))
     , mMode(RequestMode::No_cors)
     , mCredentialsMode(RequestCredentials::Omit)
@@ -413,7 +414,6 @@ class InternalRequest final
   bool mForceOriginHeader;
   bool mPreserveContentCodings;
   bool mSameOriginDataURL;
-  bool mSandboxedStorageAreaURLs;
   bool mSkipServiceWorker;
   bool mSynchronous;
   bool mUnsafeRequest;

diff --git a/dom/geolocation/nsGeolocationSettings.h b/dom/geolocation/nsGeolocationSettings.h
@@ -102,7 +102,14 @@ class GeolocationSetting final {
   inline const nsString& GetOrigin() const { return mOrigin; }
 
 private:
-  GeolocationSetting() {} // can't default construct
+  GeolocationSetting() :
+#ifdef MOZ_APPROX_LOCATION
+    mDistance(0),
+#endif
+    mLatitude(0),
+    mLongitude(0)
+  {} // can't default construct
+
   GeolocationFuzzMethod mFuzzMethod;
 #ifdef MOZ_APPROX_LOCATION
   int32_t         mDistance;

diff --git a/dom/indexedDB/IDBRequest.cpp b/dom/indexedDB/IDBRequest.cpp
@@ -51,6 +51,13 @@ NS_DEFINE_IID(kIDBRequestIID, PRIVATE_IDBREQUEST_IID);
 
 IDBRequest::IDBRequest(IDBDatabase* aDatabase)
   : IDBWrapperCache(aDatabase)
+#ifdef DEBUG
+  , mOwningThread(nullptr)
+#endif
+  , mLoggingSerialNumber(0)
+  , mLineNo(0)
+  , mColumn(0)
+  , mHaveResultOrErrorCode(false)
 {
   MOZ_ASSERT(aDatabase);
   aDatabase->AssertIsOnOwningThread();
@@ -60,6 +67,13 @@ IDBRequest::IDBRequest(IDBDatabase* aDatabase)
 
 IDBRequest::IDBRequest(nsPIDOMWindow* aOwner)
   : IDBWrapperCache(aOwner)
+#ifdef DEBUG
+  , mOwningThread(nullptr)
+#endif
+  , mLoggingSerialNumber(0)
+  , mLineNo(0)
+  , mColumn(0)
+  , mHaveResultOrErrorCode(false)
 {
   InitMembers();
 }

diff --git a/dom/messagechannel/MessagePortChild.h b/dom/messagechannel/MessagePortChild.h
@@ -19,7 +19,7 @@ class MessagePortChild final : public PMessagePortChild
 public:
   NS_INLINE_DECL_REFCOUNTING(MessagePortChild)
 
-  MessagePortChild() {}
+  MessagePortChild() : mPort(nullptr) {}
 
   void SetPort(MessagePort* aPort)
   {

diff --git a/dom/mobileconnection/MobileCallForwardingOptions.h b/dom/mobileconnection/MobileCallForwardingOptions.h
@@ -27,7 +27,13 @@ class MobileCallForwardingOptions final : public nsIMobileCallForwardingOptions
 
 private:
   // Don't try to use the default constructor.
-  MobileCallForwardingOptions() {}
+  MobileCallForwardingOptions()
+    : mActive(false)
+    , mAction(0)
+    , mReason(0)
+    , mTimeSeconds(0)
+    , mServiceClass(0)
+  {}
 
   ~MobileCallForwardingOptions() {}
 
@@ -43,4 +49,4 @@ class MobileCallForwardingOptions final : public nsIMobileCallForwardingOptions
 } // namespace dom
 } // namespace mozilla
 
-#endif // mozilla_dom_MobileCallForwardingOptions_h
+#endif // mozilla_dom_MobileCallForwardingOptions_h
diff --git a/dom/mobileconnection/ipc/MobileConnectionChild.cpp b/dom/mobileconnection/ipc/MobileConnectionChild.cpp
@@ -18,6 +18,8 @@ NS_IMPL_ISUPPORTS(MobileConnectionChild, nsIMobileConnection)
 MobileConnectionChild::MobileConnectionChild(uint32_t aServiceId)
   : mServiceId(aServiceId)
   , mLive(true)
+  , mRadioState(0)
+  , mNetworkSelectionMode(0)
 {
   MOZ_COUNT_CTOR(MobileConnectionChild);
 }

diff --git a/dom/network/UDPSocket.cpp b/dom/network/UDPSocket.cpp
@@ -118,6 +118,8 @@ UDPSocket::UDPSocket(nsPIDOMWindow* aOwner,
   : DOMEventTargetHelper(aOwner)
   , mRemoteAddress(aRemoteAddress)
   , mRemotePort(aRemotePort)
+  , mAddressReuse(false)
+  , mLoopback(false)
   , mReadyState(SocketReadyState::Opening)
 {
   MOZ_ASSERT(aOwner);

diff --git a/dom/power/PowerManagerService.h b/dom/power/PowerManagerService.h
@@ -31,6 +31,10 @@ class PowerManagerService
   NS_DECL_ISUPPORTS
   NS_DECL_NSIPOWERMANAGERSERVICE
 
+  PowerManagerService()
+    : mWatchdogTimeoutSecs(0)
+  {}
+
   static already_AddRefed<PowerManagerService> GetInstance();
 
   void Init();

diff --git a/dom/tv/TVTuner.cpp b/dom/tv/TVTuner.cpp
@@ -32,6 +32,7 @@ NS_INTERFACE_MAP_END_INHERITING(DOMEventTargetHelper)
 
 TVTuner::TVTuner(nsPIDOMWindow* aWindow)
   : DOMEventTargetHelper(aWindow)
+  , mStreamType(0)
 {
 }
 

diff --git a/dom/tv/TVTypes.cpp b/dom/tv/TVTypes.cpp
@@ -20,6 +20,7 @@ NS_IMPL_ISUPPORTS(TVTunerData, nsITVTunerData)
 TVTunerData::TVTunerData()
   : mSupportedSourceTypes(nullptr)
   , mCount(0)
+  , mStreamType(0)
 {
 }
 
@@ -275,7 +276,9 @@ TVChannelData::SetIsFree(bool aIsFree)
 NS_IMPL_ISUPPORTS(TVProgramData, nsITVProgramData)
 
 TVProgramData::TVProgramData()
-  : mAudioLanguages(nullptr)
+  : mStartTime(0)
+  , mDuration(0)
+  , mAudioLanguages(nullptr)
   , mAudioLanguageCount(0)
   , mSubtitleLanguages(nullptr)
   , mSubtitleLanguageCount(0)

diff --git a/editor/libeditor/SetDocTitleTxn.cpp b/editor/libeditor/SetDocTitleTxn.cpp
@@ -25,7 +25,8 @@ using namespace mozilla;
 // note that aEditor is not refcounted
 SetDocTitleTxn::SetDocTitleTxn()
   : EditTxn()
-, mIsTransient(false)
+  , mEditor(nullptr)
+  , mIsTransient(false)
 {
 }
 

diff --git a/editor/libeditor/nsHTMLEditRules.cpp b/editor/libeditor/nsHTMLEditRules.cpp
@@ -170,6 +170,13 @@ class nsEditableTextFunctor : public nsBoolDomIterFunctor
  ********************************************************/
 
 nsHTMLEditRules::nsHTMLEditRules()
+  : mHTMLEditor(nullptr)
+  , mListenerEnabled(false)
+  , mReturnInEmptyLIKillsList(false)
+  , mDidDeleteSelection(false)
+  , mDidRangedDelete(false)
+  , mRestoreContentEditableCount(false)
+  , mJoinOffset(0)
 {
   InitFields();
 }

diff --git a/editor/libeditor/nsHTMLEditor.cpp b/editor/libeditor/nsHTMLEditor.cpp
@@ -96,17 +96,42 @@ IsNamedAnchorTag(const nsString& s)
 nsHTMLEditor::nsHTMLEditor()
 : nsPlaintextEditor()
 , mCRInParagraphCreatesParagraph(false)
+, mCSSAware(false)
 , mSelectedCellIndex(0)
 , mIsObjectResizingEnabled(true)
 , mIsResizing(false)
+, mPreserveRatio(false)
+, mResizedObjectIsAnImage(false)
 , mIsAbsolutelyPositioningEnabled(true)
 , mResizedObjectIsAbsolutelyPositioned(false)
 , mGrabberClicked(false)
 , mIsMoving(false)
 , mSnapToGridEnabled(false)
 , mIsInlineTableEditingEnabled(true)
+, mOriginalX(0)
+, mOriginalY(0)
+, mResizedObjectX(0)
+, mResizedObjectY(0)
+, mResizedObjectWidth(0)
+, mResizedObjectHeight(0)
+, mResizedObjectMarginLeft(0)
+, mResizedObjectMarginTop(0)
+, mResizedObjectBorderLeft(0)
+, mResizedObjectBorderTop(0)
+, mXIncrementFactor(0)
+, mYIncrementFactor(0)
+, mWidthIncrementFactor(0)
+, mHeightIncrementFactor(0)
 , mInfoXIncrement(20)
 , mInfoYIncrement(20)
+, mPositionedObjectX(0)
+, mPositionedObjectY(0)
+, mPositionedObjectWidth(0)
+, mPositionedObjectHeight(0)
+, mPositionedObjectMarginLeft(0)
+, mPositionedObjectMarginTop(0)
+, mPositionedObjectBorderLeft(0)
+, mPositionedObjectBorderTop(0)
 , mGridSize(0)
 {
 }

diff --git a/editor/libeditor/nsHTMLURIRefObject.cpp b/editor/libeditor/nsHTMLURIRefObject.cpp
@@ -59,8 +59,8 @@
 #define MATCHES(tagName, str) tagName.EqualsIgnoreCase(str)
 
 nsHTMLURIRefObject::nsHTMLURIRefObject()
+  : mCurAttrIndex(0), mAttributeCnt(0)
 {
-  mCurAttrIndex = mAttributeCnt = 0;
 }
 
 nsHTMLURIRefObject::~nsHTMLURIRefObject()

diff --git a/editor/libeditor/nsTextEditRules.cpp b/editor/libeditor/nsTextEditRules.cpp
@@ -57,6 +57,15 @@ using namespace mozilla::dom;
  ********************************************************/
 
 nsTextEditRules::nsTextEditRules()
+  : mEditor(nullptr)
+  , mPasswordIMEIndex(0)
+  , mCachedSelectionOffset(0)
+  , mActionNesting(0)
+  , mLockRulesSniffing(false)
+  , mDidExplicitlySetInterline(false)
+  , mDeleteBidiImmediately(false)
+  , mLastStart(0)
+  , mLastLength(0)
 {
   InitFields();
 }

diff --git a/editor/libeditor/nsTextEditRules.h b/editor/libeditor/nsTextEditRules.h
@@ -333,14 +333,25 @@ class nsAutoLockRulesSniffing
  */
 class nsAutoLockListener
 {
-  public:
+public:
+
+  explicit nsAutoLockListener(bool *enabled)
+    : mEnabled(enabled), mOldState(false)
+  {
+    if (mEnabled) {
+      mOldState = *mEnabled;
+      *mEnabled = false;
+    }
+  }
 
-  explicit nsAutoLockListener(bool *enabled) : mEnabled(enabled)
-                 {if (mEnabled) { mOldState=*mEnabled; *mEnabled = false;}}
   ~nsAutoLockListener()
-                 {if (mEnabled) *mEnabled = mOldState;}
+  {
+    if (mEnabled) {
+      *mEnabled = mOldState;
+    }
+  }
 
-  protected:
+protected:
   bool *mEnabled;
   bool mOldState;
 };

diff --git a/editor/txtsvc/nsFilteredContentIterator.h b/editor/txtsvc/nsFilteredContentIterator.h
@@ -45,7 +45,7 @@ class nsFilteredContentIterator final : public nsIContentIterator
   void         ClearDidSkip() {  mDidSkip = false; }
 
 protected:
-  nsFilteredContentIterator() { }
+  nsFilteredContentIterator() : mDidSkip(false), mIsOutOfRange(false) { }
 
   virtual ~nsFilteredContentIterator();
 

diff --git a/gfx/2d/Logging.h b/gfx/2d/Logging.h
@@ -260,7 +260,10 @@ class Log
   // version of that method for different loggers, this is OK. Once we do,
   // change BasicLogger::ShouldOutputMessage to Logger::ShouldOutputMessage.
   explicit Log(int aOptions = Log::DefaultOptions(L == LOG_CRITICAL),
-               LogReason aReason = LogReason::MustBeMoreThanThis) {
+               LogReason aReason = LogReason::MustBeMoreThanThis)
+  : mOptions(0)
+  , mLogIt(false)
+  {
     Init(aOptions, BasicLogger::ShouldOutputMessage(L), aReason);
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,6 +32,7 @@ NS_INTERFACE_MAP_END_INHERITING(DOMEventTargetHelper) @@
     TVTuner::TVTuner(nsPIDOMWindow* aWindow)
       : DOMEventTargetHelper(aWindow)
+      , mStreamType(0)
     {
     }
@@ Expand Down @@