forked from apache/geode
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Geode-8853: DUNIT tests for HSTRLEN command (apache#5939)
- test the error messages for hgetall and hstrlen more specifically - fix an hgetall test that was testing the wrong command Co-authored-by: Ray Ingles <[email protected]> Co-authored-by: Helena A. Bales <[email protected]>
- Loading branch information
3 people
authored
Jan 26, 2021
1 parent
b46a0a2
commit 3ddd9da
Showing
4 changed files
with
158 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
.../distributedTest/java/org/apache/geode/redis/internal/executor/hash/HstrlenDUnitTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more contributor license | ||
| * agreements. See the NOTICE file distributed with this work for additional information regarding | ||
| * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. You may obtain a | ||
| * copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package org.apache.geode.redis.internal.executor.hash; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import java.util.Random; | ||
|
|
||
| import org.junit.Before; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.ClassRule; | ||
| import org.junit.Test; | ||
| import redis.clients.jedis.Jedis; | ||
|
|
||
| import org.apache.geode.redis.ConcurrentLoopingThreads; | ||
| import org.apache.geode.test.awaitility.GeodeAwaitility; | ||
| import org.apache.geode.test.dunit.rules.MemberVM; | ||
| import org.apache.geode.test.dunit.rules.RedisClusterStartupRule; | ||
|
|
||
| public class HstrlenDUnitTest { | ||
|
|
||
| @ClassRule | ||
| public static RedisClusterStartupRule clusterStartUp = new RedisClusterStartupRule(4); | ||
|
|
||
| private static final String LOCAL_HOST = "127.0.0.1"; | ||
| private static final int JEDIS_TIMEOUT = | ||
| Math.toIntExact(GeodeAwaitility.getTimeout().toMillis()); | ||
| private static Jedis jedis1; | ||
| private static Jedis jedis2; | ||
| private static Jedis jedis3; | ||
|
|
||
| @BeforeClass | ||
| public static void classSetup() { | ||
| MemberVM locator = clusterStartUp.startLocatorVM(0); | ||
| clusterStartUp.startRedisVM(1, locator.getPort()); | ||
| clusterStartUp.startRedisVM(2, locator.getPort()); | ||
|
|
||
| int redisServerPort1 = clusterStartUp.getRedisPort(1); | ||
| int redisServerPort2 = clusterStartUp.getRedisPort(2); | ||
|
|
||
| jedis1 = new Jedis(LOCAL_HOST, redisServerPort1, JEDIS_TIMEOUT); | ||
| jedis2 = new Jedis(LOCAL_HOST, redisServerPort2, JEDIS_TIMEOUT); | ||
| jedis3 = new Jedis(LOCAL_HOST, redisServerPort1, JEDIS_TIMEOUT); | ||
| } | ||
|
|
||
| @Before | ||
| public void testSetup() { | ||
| jedis1.flushAll(); | ||
| } | ||
|
|
||
| @Test | ||
| public void hstrlenDoesNotCorruptData_whileHashIsConcurrentlyUpdated() { | ||
| String key = "key"; | ||
| String field = "field"; | ||
| int iterations = 10000; | ||
| Random rand = new Random(); | ||
|
|
||
| jedis1.hset(key, field, "22"); | ||
|
|
||
| new ConcurrentLoopingThreads(iterations, | ||
| (i) -> { | ||
| int newLength = rand.nextInt(9) + 1; | ||
| String newVal = makeStringOfRepeatedDigits(newLength); | ||
| jedis1.hset(key, field, newVal); | ||
| }, | ||
| (i) -> assertThat(jedis2.hstrlen(key, field)).isBetween(1L, 9L), | ||
| (i) -> assertThat(jedis3.hstrlen(key, field)).isBetween(1L, 9L)) | ||
| .run(); | ||
|
|
||
| String value = jedis1.hget(key, field); | ||
| String encodedStringLength = Character.toString(value.charAt(0)); | ||
| int expectedLength = Integer.parseInt(encodedStringLength); | ||
| assertThat(jedis2.hstrlen(key, field)).isEqualTo(expectedLength); | ||
| } | ||
|
|
||
| private String makeStringOfRepeatedDigits(int newLength) { | ||
| String stringOfRepeatedDigits = ""; | ||
| for (int i = 0; i < newLength; i++) { | ||
| stringOfRepeatedDigits += newLength; | ||
| } | ||
| return stringOfRepeatedDigits; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters