fixed file loader and production builder

robert9g · Sep 7, 2017 · 8e4fa3d · 8e4fa3d
1 parent 54f1ee5
commit 8e4fa3d
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 8 deletions.
diff --git a/client/src/components/list_item_view.js b/client/src/components/list_item_view.js
@@ -28,7 +28,11 @@ class ListItemView extends Component {
 ListItemView.propTypes = {
   viewItem: PropTypes.func.isRequired,
   match: PropTypes.object.isRequired,
-  item: PropTypes.object.isRequired,
+  item: PropTypes.object,
+};
+
+ListItemView.defaultProps = {
+  item: null,
 };
 
 export default ListItemView;
diff --git a/webpack/client.prod.js b/webpack/client.prod.js
@@ -1,4 +1,5 @@
 const path = require('path');
+const webpack = require('webpack');
 const UglifyJSPlugin = require('uglifyjs-webpack-plugin');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
 
@@ -12,6 +13,7 @@ module.exports = {
   output: {
     path: path.join(__dirname, '../server/public'),
     filename: './js/index.js',
+    publicPath: '/',
   },
   module: {
     rules: [{
@@ -33,18 +35,21 @@ module.exports = {
       },
       {
         test: /\.(png|jpg|gif)$/,
-        use: [
-          {
-            loader: 'file-loader',
-            options: {
-              outputPath: 'images/',
-            }  
+        use: [{
+          loader: 'file-loader',
+          options: {
+            outputPath: 'images/',
           }
-        ]
+        }]
       },
     ],
   },
   plugins: [
+    new webpack.DefinePlugin({
+      'process.env': {
+        'NODE_ENV': JSON.stringify('production')
+      }
+    }),
     new UglifyJSPlugin({
       sourceMap: true
     }),

diff --git a/webpack/server.prod.js b/webpack/server.prod.js
@@ -1,4 +1,5 @@
 const path = require('path');
+const webpack = require('webpack');
 const UglifyJSPlugin = require('uglifyjs-webpack-plugin');
 const nodeExternals = require('webpack-node-externals');
 
@@ -40,6 +41,11 @@ module.exports = {
     ],
   },
   plugins: [
+    new webpack.DefinePlugin({
+      'process.env': {
+        'NODE_ENV': JSON.stringify('production')
+      }
+    }),
     new UglifyJSPlugin({
       sourceMap: true
     }),