odp-execute: Fix memory leak on recirc action

If odp_execute_actions() has been called with 'steal' set to true and OVS_ACTION_ATTR_RECIRC as last action, it should allow dp_execute_cb() to steal the packet. Signed-off-by: Daniele Di Proietto <[email protected]> Acked-by: Jarno Rajahalme <[email protected]>
robin-zhou · Oct 3, 2014 · 0057762 · 0057762
1 parent d73803c
commit 0057762
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
@@ -422,8 +422,7 @@ odp_execute_actions__(void *dp, struct dpif_packet **packets, int cnt,
                 /* Allow 'dp_execute_action' to steal the packet data if we do
                  * not need it any more. */
                 bool may_steal = steal && (!more_actions
-                                           && left <= NLA_ALIGN(a->nla_len)
-                                           && type != OVS_ACTION_ATTR_RECIRC);
+                                           && left <= NLA_ALIGN(a->nla_len));
                 dp_execute_action(dp, packets, cnt, md, a, may_steal);
             }
             break;